Qt: Add missing gamelist contextmenu options #5353

spycrab · 2017-05-01T16:41:17Z

Adds a few missing gamelist menu options that are available in the Wx Version, but not in Qt.

Open containing folder
Delete File
Compress ISO
Open Wii save folder
Export Wii save folder
Install WADs
Uninstall WADs
Add the items listed above to the top menubar (only to those applicable) (optional, can (and maybe should) be done in a later PR)

Source/Core/DolphinQt2/GameList/GameList.cpp

+
+      if (deletion_successful)
+      {
+        // TODO Reload the game list


Source/Core/DolphinQt2/GameList/GameFile.h

@@ -65,6 +65,10 @@ class GameFile final
  QString GetLongName(DiscIO::Language lang) const { return m_long_names[lang]; }
  QString GetLongMaker(DiscIO::Language lang) const { return m_long_makers[lang]; }
  QString GetDescription(DiscIO::Language lang) const { return m_descriptions[lang]; }
+  // Actions


Source/Core/DolphinQt2/GameList/GameList.cpp

  QMenu* menu = new QMenu(this);
  DiscIO::Platform platform = GameFile(GetSelectedGame()).GetPlatformID();
+  menu->addAction(tr("Properties"), this, SLOT(OpenProperties()),


Source/Core/DolphinQt2/GameList/GameList.cpp

+void GameList::OpenContainingFolder()
+{
+  std::cout << GameFile(GetSelectedGame()).GetInternalName().toStdString() << std::endl;
+  QString url = QStringLiteral("file://").append(QFileInfo(GetSelectedGame()).dir().absolutePath());


Source/Core/DolphinQt2/GameList/GameFile.cpp

+
+  const std::string path =
+      StringFromFormat("%s/title/%08x/%08x/data/", File::GetUserPath(D_WIIROOT_IDX).c_str(),
+                       (u32)(title_id >> 32), (u32)title_id);


Source/Core/DolphinQt2/GameList/GameFile.h

@@ -52,6 +52,7 @@ class GameFile final
  DiscIO::Country GetCountryID() const { return m_country; }
  QString GetCountry() const;
  DiscIO::BlobType GetBlobType() const { return m_blob_type; }
+  QString GetWiiFSPath();


Source/Core/DolphinQt2/GameList/GameList.cpp

+
+void GameList::OpenSaveFolder()
+{
+  QString url = QStringLiteral("file://").append(GameFile(GetSelectedGame()).GetWiiFSPath());


Source/Core/DolphinQt2/GameList/GameList.cpp

+
+      if (deletion_successful)
+      {
+        // TODO Reload the game list


Source/Core/DolphinQt2/GameList/GameList.cpp

@@ -105,18 +112,36 @@ void GameList::MakeListView()

 void GameList::ShowContextMenu(const QPoint&)
 {
+  if (GetSelectedGame().isEmpty())


Source/Core/DolphinQt2/GameList/GameFile.cpp

@@ -21,6 +23,8 @@
 static const int CACHE_VERSION = 13;  // Last changed in PR #3261
 static const int DATASTREAM_VERSION = QDataStream::Qt_5_5;

+u64 GetTitleID(QString);


Source/Core/DolphinQt2/GameList/GameList.cpp

+  QString file_types;
+  QString default_file = QFileInfo(GetSelectedGame()).dir().absoluteFilePath(file.GetGameID());
+
+  std::cout << default_file.toStdString() << std::endl;


Source/Core/DolphinQt2/GameList/GameList.cpp

+                                      16384, &CompressCB, &progress_dialog);
+
+  if (good)
+    QMessageBox(QMessageBox::Information, tr("Success!"), tr("Successfully compressed image."),


Source/Core/DolphinQt2/GameList/GameList.cpp

+  const auto original_path = GetSelectedGame();
+  auto file = GameFile(original_path);
+
+  bool compressed = file.GetBlobType() == DiscIO::BlobType::GCZ;


Source/Core/DolphinQt2/GameList/GameList.cpp

+{
+  if (ptr == nullptr)
+    return false;
+  auto* prg = reinterpret_cast<QProgressDialog*>(ptr);


Source/Core/DolphinQt2/GameList/GameList.cpp

+  bool good;
+
+  if (compressed)
+    good = DiscIO::DecompressBlobToFile(original_path.toStdString(), dst_path.toStdString(),


Source/Core/DolphinQt2/GameList/GameList.cpp

+
+  prg->setValue(percent * 100);
+  return !prg->wasCanceled();
+}


Source/Core/DolphinQt2/GameList/GameFile.cpp

@@ -21,6 +23,8 @@
 static const int CACHE_VERSION = 13;  // Last changed in PR #3261
 static const int DATASTREAM_VERSION = QDataStream::Qt_5_5;

+static inline u64 GetTitleID(const QString&);


Source/Core/DolphinQt2/GameList/GameFile.cpp

@@ -291,6 +295,79 @@ QString GameFile::GetLanguage(DiscIO::Language lang) const
  }
 }

+bool GameFile::IsInstalled()


Source/Core/DolphinQt2/GameList/GameList.cpp

+
+  const bool compressed = (file.GetBlobType() == DiscIO::BlobType::GCZ);
+
+  QString label_text = tr("Select where you want to save the ");


Source/Core/DolphinQt2/GameList/GameList.cpp

+    menu->addAction(tr("Default ISO"), this, SLOT(SetDefaultISO()),
+                    QKeySequence(tr("D", "Set as Default ISO")));
+    menu->addAction(GameFile(game).GetBlobType() == DiscIO::BlobType::GCZ ? tr("Decompress ISO") :
+                                                                            tr("Compress ISO"),


Source/Core/DolphinQt2/GameList/GameFile.cpp

+  const auto volume = DiscIO::CreateVolumeFromFilename(path.toStdString());
+
+  u64 title_id;
+  volume->GetTitleID(&title_id);


Source/Core/DolphinQt2/GameList/GameList.cpp

+      wii_warning.setIcon(QMessageBox::Warning);
+      wii_warning.setText(tr("Are you sure?"));
+      wii_warning.setInformativeText(tr("Compressing Wii ISOs is an irreversible process. Your "
+                                        "image will keep working as usual."));


Source/Core/DolphinQt2/MenuBar.cpp

+  }
+
+  result_dialog.exec();
+}


Source/Core/DolphinQt2/GameList/GameFile.cpp

@@ -21,6 +23,16 @@
 static const int CACHE_VERSION = 13;  // Last changed in PR #3261
 static const int DATASTREAM_VERSION = QDataStream::Qt_5_5;

+u64 GetTitleID(const QString& path)


Source/Core/DolphinWX/GameListCtrl.cpp

@@ -502,7 +502,7 @@ void CGameListCtrl::ReloadList()
    }
    else
    {
-      errorString = _("Dolphin could not find any GameCube/Wii ISOs or WADs. Double-click here to "
+      errorString = _("Dolphin could not find any GameCube/WiiISOs or WADs. Double-click here to "


Source/Core/DolphinQt2/GameList/GameFile.cpp

+    return false;
+
+  const std::string content_dir =
+      Common::GetTitleContentPath(m_title_id, Common::FromWhichRoot::FROM_CONFIGURED_ROOT);


Source/Core/DolphinQt2/GameList/GameFile.cpp

+  const auto entries = File::ScanDirectoryTree(content_dir, false);
+  return std::any_of(entries.children.begin(), entries.children.end(),
+                     [](const auto& file) { return file.virtualName != "title.tmd"; });
+}


Source/Core/DolphinQt2/GameList/GameFile.cpp

+
+bool GameFile::Install()
+{
+  if (m_platform != DiscIO::Platform::WII_WAD)


Source/Core/DolphinQt2/GameList/GameFile.cpp

+
+bool GameFile::Uninstall()
+{
+  if (m_platform != DiscIO::Platform::WII_WAD)


Source/Core/DolphinQt2/GameList/GameFile.cpp

+                                                           Common::FROM_CONFIGURED_ROOT);
+}
+
+bool GameFile::ExportWiiSaves()


Source/Core/DolphinQt2/GameList/GameList.cpp

+  const bool success = GameFile(GetSelectedGame()).Uninstall();
+
+  result_dialog.setIcon(success ? QMessageBox::Information : QMessageBox::Critical);
+  result_dialog.setText(success ? tr("Succesfully removed WAD from NAND") :


Source/Core/DolphinQt2/GameList/GameList.cpp

+
+  result_dialog.setIcon(success ? QMessageBox::Information : QMessageBox::Critical);
+  result_dialog.setText(success ? tr("Succesfully removed WAD from NAND") :
+                                  tr("Failed to remove WAD from NAND"));


Source/Core/DolphinQt2/MenuBar.cpp

+  if (GameFile(wad_file).Install())
+  {
+    result_dialog.setIcon(QMessageBox::Information);
+    result_dialog.setText(tr("Successfully installed the WAD to NAND"));


Source/Core/DolphinQt2/MenuBar.cpp

+  else
+  {
+    result_dialog.setIcon(QMessageBox::Critical);
+    result_dialog.setText(tr("Failed to install the WAD to NAND!"));


Source/Core/DolphinQt2/GameList/GameList.cpp

+  result_dialog.exec();
+}
+
+void GameList::UninstallWAD()


Source/Core/DolphinQt2/GameList/GameFile.cpp

+
+bool GameFile::Uninstall()
+{
+  _assert_(m_platform == DiscIO::Platform::WII_WAD)


BhaaLseN reviewed May 1, 2017

View reviewed changes

Source/Core/DolphinQt2/GameList/GameList.cpp Outdated

if (deletion_successful)

{

// TODO Reload the game list

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

spycrab force-pushed the qt_contextmenu branch from ce798b7 to b75f0d6 Compare May 1, 2017 18:32

spycrab changed the title ~~Qt: Add (a few) missing menu options~~ Qt: Add missing gamelist contextmenu options May 1, 2017

spycrab force-pushed the qt_contextmenu branch from b75f0d6 to 868dfd3 Compare May 1, 2017 18:58

lioncash reviewed May 1, 2017

View reviewed changes

spycrab force-pushed the qt_contextmenu branch 3 times, most recently from 1578ccc to 4177a39 Compare May 1, 2017 22:03

lioncash reviewed May 1, 2017

View reviewed changes

spycrab force-pushed the qt_contextmenu branch 4 times, most recently from 740456e to f751b8f Compare May 2, 2017 14:45

Helios747 approved these changes May 2, 2017

View reviewed changes

spycrab force-pushed the qt_contextmenu branch 2 times, most recently from c2581b2 to 730af06 Compare May 2, 2017 20:17

lioncash reviewed May 2, 2017

View reviewed changes

spycrab force-pushed the qt_contextmenu branch from 730af06 to a5e8c0f Compare May 2, 2017 20:27

JosJuice reviewed May 2, 2017

View reviewed changes

spycrab force-pushed the qt_contextmenu branch 3 times, most recently from 2519ac5 to 3aefbe5 Compare May 3, 2017 14:26

JosJuice reviewed May 3, 2017

View reviewed changes

spycrab force-pushed the qt_contextmenu branch from 3aefbe5 to b3293b2 Compare May 3, 2017 14:45

leoetlino requested changes May 4, 2017

View reviewed changes

spycrab force-pushed the qt_contextmenu branch 3 times, most recently from 4d84e92 to 41fcaea Compare May 4, 2017 20:54

leoetlino reviewed May 4, 2017

View reviewed changes

Source/Core/DolphinQt2/GameList/GameFile.cpp Outdated

bool GameFile::Uninstall()

{

_assert_(m_platform == DiscIO::Platform::WII_WAD)

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Qt: Add missing gamelist contextmenu options

2f523af

spycrab force-pushed the qt_contextmenu branch from 41fcaea to 2f523af Compare May 4, 2017 21:01

leoetlino approved these changes May 4, 2017

View reviewed changes

leoetlino merged commit e957110 into dolphin-emu:master May 4, 2017

spycrab deleted the qt_contextmenu branch May 4, 2017 22:21

leoetlino modified the milestone: Qt Sep 13, 2017


		const bool compressed = (file.GetBlobType() == DiscIO::BlobType::GCZ);

		QString label_text = tr("Select where you want to save the ");

Qt: Add missing gamelist contextmenu options #5353

Qt: Add missing gamelist contextmenu options #5353

Conversation

spycrab commented May 1, 2017 • edited Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

spycrab commented May 1, 2017 •

edited

Loading