DolphinQt2: Don't use a mutex in GameFileCache #6284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Jan 4, 2018
| @@ -26,5 +26,4 @@ class GameFileCache | |||
| QString m_path; | |||
|
|
|||
| QMap<QString, GameFile> m_gamefiles; | |||
| std::mutex m_mutex; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
lioncash
reviewed
Jan 4, 2018
| @@ -74,14 +66,10 @@ void GameFileCache::Save() | |||
|
|
|||
| void GameFileCache::Update(const GameFile& gamefile) | |||
| { | |||
| std::lock_guard<std::mutex> guard(m_mutex); | |||
|
|
|||
| m_gamefiles[gamefile.GetFilePath()] = gamefile; | |||
| } | |||
|
|
|||
| QList<QString> GameFileCache::GetCached() | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
lioncash
reviewed
Jan 4, 2018
| @@ -22,22 +22,16 @@ GameFileCache::GameFileCache() | |||
|
|
|||
| bool GameFileCache::IsCached(const QString& path) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
GameTracker's usage of GameFileCache is thread-safe even without using a mutex. All of its access to GameFileCache happens on the thread m_load_thread, except for the call to GameFileCache::Load, which finishes before m_load_thread starts executing.
JosJuice
force-pushed
the
qt-gamefilecache-mutex
branch
from
2979fdf
to
e44b64b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GameTracker's usage of GameFileCache is thread-safe even without using a mutex. All of its access to GameFileCache happens on the thread m_load_thread, except for the call to GameFileCache::Load, which finishes before m_load_thread starts executing.