Qt: Implement GameCube memcard manager

[spycrab]

[lioncash]

For whatever reason GitHub won't load the .cpp file for GCMemcardManager (even in different browsers) for me, so I'll have to do this old-school bulleted-list style.

Line:

• 7: <iostream> should probably be removed.

• 130: if (m_slot_memcard[slot] != nullptr) can be inverted to unindent the large body of code it contains.

• 132, 218, 291, 313, 348, 362:

auto* memcard = m_slot_memcard[m_active_slot].get();

can likely just be:

auto& memcard = m_slot_memcard[m_active_slot];

since it's only ever used to call GCMemcard functions.

• 368:

std::vector<QPixmap> images;
images.resize(2);

can be:

std::vector<QPixmap> images(2);

• 383: <algorithm> should be included
• 407: image.fill(0xFFFFFFFF); can likely be changed to image.fill(Qt::white);.

Other:

• i < 2 seems to be quite frequent as the condition for loops, perhaps it would be better to use a constant like NUM_SLOTS in these cases. e.g.

class blah
{
public:

  // ...

private:
  // ...

  // Slots
  static constexpr int NUM_SLOTS = 2;
  std::array<std::unique_ptr<GCMemcard>, NUM_SLOTS> m_slot_memcard;
  std::array<QGroupBox*, NUM_SLOTS> m_slot_group;
  std::array<QLineEdit*, NUM_SLOTS> m_slot_file_edit;
  std::array<QPushButton*, NUM_SLOTS> m_slot_file_button;
  std::array<QTableWidget*, NUM_SLOTS> m_slot_table;
  std::array<QLabel*, NUM_SLOTS> m_slot_stat_label;
};

or

class blah
{
public:
  // ...

private:
  // ...

  // Slots
  struct Slot
  {
    std::unique_ptr<GCMemcard> memcard;
    QGroupBox* group;
    QLineEdit* file_edit;
    QPushButton* file_button;
    QTableWidget* table;
    QLabel* stat_label;
  };

  static constexpr int NUM_SLOTS = 2;
  std::array<Slot, NUM_SLOTS> m_slot;
};

then just use that.

[JMC47]

Everything is working fine here, but, I have a stupid request. Some of the saves have an animated icon. Can we animate those in the menu? I know that's a dumb request, but it'd look super cool and make the icon menu look better. Alternatively, only show the first image in an animation since it makes it look super awkward.

[JMC47]

I've run into some bugs as well. There's a lot of garbage text in some entries, such as my Mario Tennis one having wierd things. Will grab some screenshots on my other PC.

[JMC47]

[spycrab]

@lioncash Addressed your points unless noted otherwise.
@JMC47 Decoding issue mostly fixed (I hope)
Also icons are animated now.

[spycrab]

@JMC47 Good to go now? Or is there still something that bothers you?

[JMC47]

Everything is good here. I want to feature this in the progress report if it can be merged today.