Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code #6568

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Remove dead code #6568

merged 1 commit into from
Mar 31, 2018

Conversation

leoetlino
Copy link
Member

Unused, old code that is intended to be removed should not be left in comments -- that is what version control is for.

@leoetlino
Remove dead code
c82da2b 
Unused, old code that is intended to be removed should not be left in
comments -- that is what version control is for.
BhaaLseN
BhaaLseN approved these changes Mar 31, 2018
View reviewed changes
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that commented out case for P_ACCM_D means anything (like, we should be implementing it); but otherwise LGTM. No need to leave dead code around.

@lioncash lioncash merged commit a6f1c6e into dolphin-emu:master Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@BhaaLseN BhaaLseN BhaaLseN approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leoetlino @lioncash @BhaaLseN