Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiimoteDevice: Amend variable naming #7106

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Conversation

lioncash
Copy link
Member

This source file is kind of wild when it comes to our naming guidelines compared to every other source file. This brings it a little more in-line with how the variables should be named within the codebase.

I've kept the renaming in two halves to make it nicer to review, which can be squashed down when reviewing is done, or merged as is, depending on preference.

This file is quite out of sync when it comes to our naming conventions,
this brings it back in line with it.
Gets rid of inconsistencies related to class variables concerning casing
and the lack of prefixes on some variables, while others contain them.
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 👍

@leoetlino leoetlino merged commit f3a18db into dolphin-emu:master Jun 11, 2018
@lioncash lioncash deleted the name branch June 11, 2018 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants