IOS: Improve timing accuracy for title launches (both ARM and PPC) #9545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
force-pushed
the
es-launch-timings
branch
from
b6329e8
to
b5eb829
Compare
sepalani
reviewed
Mar 2, 2021
BhaaLseN
reviewed
Mar 2, 2021
|
Changes seem good, but this time I'll wait with approving until testing is done. |
iwubcode
approved these changes
Mar 4, 2021
|
You still have |
Low MEM1 is cleared by IOS before all the other constants are written. This will overwrite the Gecko code handler but it should be fine because HLE::Reload (which will set up the code handler hook again) will be called after a title change is detected.
Reading the boot content from the NAND takes a non-negligible amount of time and the PPC should be held in reset while the DOL is being read.
The extra IPC ack is triggered by a syscall that is invoked in ES's main function; the syscall literally just sets Y2, IX1 and IX2 in HW_IPC_ARMCTRL -- there is no complicated ack queue or anything.
We should only try to load a symbol map for the new title *after* it has been loaded into memory, not before. Likewise for applying HLE patches and loading new custom textures. In practice, loading/repatching too early was only a problem for titles that are launched via ES_Launch. This commit fixes that.
The PPC is supposed to be held in reset when another version of IOS is in the process of being launched for a PPC title launch. Probably doesn't matter in practice, though the inaccuracy was definitely observable from the PPC.
Also gets rid of one static variable
leoetlino
force-pushed
the
es-launch-timings
branch
from
9469880
to
aef0760
Compare
|
Squashed and rebased |
leoetlino
added
QA done
|
I forgot to post I tested this with Ocarina of Time, Super Smash Bros. Brawl, and Metroid Prime Trilogy among other titles. |
leoetlino
added a commit
to leoetlino/dolphin
that referenced
this pull request
Apr 22, 2021
Oversight from dolphin-emu#9545, which moved the "new game has been loaded" logic to a separate OnNewTitleLoad function that has to be called explicitly *after* a title has loaded.
leoetlino
added a commit
to leoetlino/dolphin
that referenced
this pull request
Apr 22, 2021
Oversight from dolphin-emu#9545, which moved the "new game has been loaded" logic to a separate OnNewTitleLoad function that has to be called explicitly *after* a title has loaded. Coupled with the commit that makes Dolphin not clobber 0x1800-0x3000 when using MIOS, this fixes Wind Waker and other MIOS-patched games when they are launched from the System Menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(alternative title: make ES_Launch slower and potentially break it)
This is a series of commits to make ES launch timings closer to console:
(those commits can be reviewed one at a time)
This PR also simplifies IPC reinitialisation after an IOS relaunch and makes it more accurate. Contrary to what the current code suggests, there is no complicated ack queue or anything. The extra IPC ack is actually triggered by a syscall that is invoked in ES's main function; the syscall literally just sets Y2, IX1 and IX2 in HW_IPC_ARMCTRL.
Needs careful testing because ES_Launch is cursed