NetPlay: Sync more settings #9571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
netplay-sync-more-settings
branch
2 times, most recently
from
f70c1ce
to
7397f0f
Compare
leoetlino
reviewed
Mar 7, 2021
Avoiding desyncs is more important than honoring what the user specified on the command line.
Fixes netplay and movie overrides of SYSCONF settings not applying.
Whether the custom RTC setting is enabled shouldn't in itself affect determinism (as long as the actual RTC value is properly synced). Alters the logic added in 4b2906c. I'm not entirely certain that this is correct, but the current code doesn't really make sense to me... If we need to force the RTC bias to 0 when custom RTC is enabled, why don't we need to do it when custom RTC is disabled? The code for getting the host system's current time doesn't contain any special handling for the guest's RTC bias as far as I can tell.
JosJuice
force-pushed
the
netplay-sync-more-settings
branch
from
456da59
to
1dfeb73
Compare
leoetlino
reviewed
Mar 16, 2021
Source/Core/Core/BootManager.cpp
Outdated
| if (StartUp.bWii) | ||
| { | ||
| Core::BackupWiiSettings(); | ||
| ConfigLoaders::SaveToSYSCONF(Config::LayerType::Meta); | ||
| const bool want_determinism = Movie::IsMovieActive() || NetPlay::IsNetPlayRunning(); |
There was a problem hiding this comment.
Is it possible to use Core::UpdateWantDeterminism(true) and Core::WantsDeterminism here?
edit: If we use UpdateWantDeterminism, the call would have to be outside the bWii conditional.
There was a problem hiding this comment.
I've added a commit that does this.
Just to make the InitializeWiiRoot call a bit neater.
leoetlino
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes certain netplay desyncs, https://bugs.dolphin-emu.org/issues/10328, and a bug where the Wii language stored in a DTM file would be ignored. Prerequisite for PR #9388.