1.43.6

Merged PRs

dolt

• 8450: log server metrics heartbeat
  fixes: #8443

go-mysql-server

• 2704: fix cascade for foreign keys with multiple references
  This PR fixes an issue where foreign keys referencing the same column would fail to update the parent table (only on GMS).
  Turns out we were adding the updater in the chain under the parent table's name instead of the child's name.
  Additionally, has some small refactoring to tidy up the foreign key chain code.
  fixes: dolthub/go-mysql-server#2671
• 2703: Minor changes for implicit prefix lengths in Doltgres
  Minor changes to support dolthub/doltgresql#829
• 2700: compare and convert system types properly
  Changes:
  • IsType() methods now account for system variable types,
  • coalesce type comparison accounts for system variable types
  • create table from select ... statements account for system variable types
    Note: MySQL lists @@admin_port as Integer in their docs, but shows up as UInteger in the CLI
    fixes: #8448
• 2699: resolve column defaults for views
  Properly display defaults for views.
  Also fixes defaults for views with filters.
  fixes: #8447
• 2696: clear warnings better and separate warning count from actual warnings
  This PR cleans up the logic surrounding warnings and clearing them.
  The important part was separating the number of "new" warnings from the list of warnings themselves.
  Every query should clear out the warnings from the previous query. The exception is show warnings, which only clears the "count" of warnings.
  When a server runs a query that produces a warning, it immediately calls show warnings. Since the show warnings query itself should NOT clear the warnings, the warning count would always be > 0, and incorrectly indicate that show warnings produced a warning. This causes an infinite loop in .NET. Now, we always clear the warning count, and only clear the warnings themselves when the query is not show warnings.
  We've also had this weird problem of having to double clear warnings, which this should address.
  fixes:
  • #8440
  • #6921

vitess

• 371: support quoted character set values
  This PR adds syntax support for quoted character set values.
  fix: #8455
• 370: Collapse union types
  Replace union type with one interface type. Static type access in reducer stack become runt-time interface conversions. The compiler builder loses the ability to do type checking at build time, so type safety has to be checked with testing.
  Additional type enforcements are needed for nil-safety. Nil return values have to be typed correctly in the interface variable for casts up the stack to pass. Interface types do not have default nil values, so I've added tryCastXXX helper functions to accommodate untyped nils.

Closed Issues

• 8455: quoted character set value is not supported
• 8447: ERROR: 1105 (HY000): handler caught panic: UnresolvedColumnDefault is a placeholder node, but Type() was called
• 8448: Incorrect type inference for COALESCE of system variables
• 8443: Log metrics calls to eventsapi.dolthub.com in the Dolt server logs at appropriate log levels
• 8440: Connector/NET: A warning causes stack overflow
• 2671: setting two foreign keys to associate with the same field, deleting data is normal but does not take effect

Performance

Read Tests	MySQL	Dolt	Multiple
covering_index_scan	2.11	0.62	0.3
groupby_scan	13.22	16.71	1.3
index_join	1.34	2.3	1.7
index_join_scan	1.25	1.89	1.5
index_scan	34.33	56.84	1.7
oltp_point_select	0.18	0.27	1.5
oltp_read_only	3.49	5.47	1.6
select_random_points	0.34	0.61	1.8
select_random_ranges	0.39	0.62	1.6
table_scan	34.33	56.84	1.7
types_table_scan	74.46	144.97	1.9
reads_mean_multiplier			1.5

Write Tests	MySQL	Dolt	Multiple
oltp_delete_insert	8.13	5.88	0.7
oltp_insert	3.82	2.91	0.8
oltp_read_write	8.58	11.24	1.3
oltp_update_index	3.89	2.97	0.8
oltp_update_non_index	3.89	2.91	0.7
oltp_write_only	5.37	5.99	1.1
types_delete_insert	7.84	6.43	0.8
writes_mean_multiplier			0.9

TPC-C TPS Tests	MySQL	Dolt	Multiple
tpcc-scale-factor-1	98.91	40.71	2.4
tpcc_tps_multiplier			2.4

Overall Mean Multiple	1.60