Skip to content

Add +web-react-mode snippets #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2020
Merged

Conversation

sei40kr
Copy link
Contributor

@sei40kr sei40kr commented Jan 21, 2020

Description

  1. Add +web-react-mode snippets
  2. Remove createClass because React.createClass({...}) is not recommended

Copy link
Member

@hlissner hlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a minor detail, but please move the contributor field above name:. I prefer to group aesthetic fields away from functional ones.

@sei40kr
Copy link
Contributor Author

sei40kr commented Jan 23, 2020

@hlissner I've updated the PR.

@sei40kr sei40kr requested a review from hlissner January 29, 2020 14:54
@hlissner hlissner added mode:+web-react is:snippet Requests that a snippet be added or removed labels Feb 2, 2020
@hlissner hlissner merged commit 22c96ef into doomemacs:master Feb 2, 2020
@hlissner
Copy link
Member

hlissner commented Feb 2, 2020

Looks good to me! Thanks for all your PRs!

hlissner added a commit to doomemacs/doomemacs that referenced this pull request Feb 2, 2020
GTrunSec pushed a commit to GTrunSec/doom-emacs that referenced this pull request Feb 9, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
is:snippet Requests that a snippet be added or removed mode:+web-react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants