Skip to content

Fix buffer mutation in C++ access modifiers. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

Fix buffer mutation in C++ access modifiers. #47

merged 1 commit into from
Jul 29, 2020

Conversation

Janfel
Copy link
Contributor

@Janfel Janfel commented Jul 29, 2020

This PR replaces the calls to indent-according-to-mode in the snippets for the C++ access modifiers with the expand-env property. This causes the snippets to no longer mutate the buffer and fixes the corresponding warning from Yasnippet.

@hlissner hlissner added is:feature Adds or requests new features, or extends existing ones mode:c++ labels Jul 29, 2020
@hlissner hlissner merged commit 60c57d6 into doomemacs:master Jul 29, 2020
@hlissner
Copy link
Member

Thanks!

@Janfel Janfel deleted the fix-buffer-mutation branch July 29, 2020 23:12
Janfel added a commit to Janfel/doom-emacs-config that referenced this pull request Oct 16, 2020
@Janfel
Remove workaround doomemacs/snippets/pull/47.
10d6c8f
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hlissner hlissner hlissner approved these changes

Assignees
No one assigned
Labels
is:feature Adds or requests new features, or extends existing ones mode:c++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janfel @hlissner