Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add friendly message when there are no rules #16792

Closed
wezell opened this issue Jun 27, 2019 · 7 comments
Closed

Add friendly message when there are no rules #16792

wezell opened this issue Jun 27, 2019 · 7 comments
Assignees
@hmoreras
Labels
Doc : Needs Translation QA : Approved QA : Passed Internal Release : 5.2.0 Type : Enhancement
Milestone
5.1.6_07222019_FOX

Comments

@wezell
Copy link
Contributor

wezell commented Jun 27, 2019

When you click rules and there are none, you get a big blank page. We need to show a friendly message that can be displayed when there are no rules created. label: needs UI

Screen Shot 2019-06-27 at 3 47 34 PM
@wezell wezell added this to the Fox Current milestone Jun 27, 2019
@hmoreras hmoreras self-assigned this Jul 10, 2019
fmontes pushed a commit that referenced this issue Jul 11, 2019
@hmoreras @fmontes
#16792 Add friendly message when there are no rules
ddea62a
@fmontes
Copy link
Member

fmontes commented Jul 12, 2019

As per @wezell we're not adding the icon.

fmontes pushed a commit to dotCMS/core-web that referenced this issue Jul 12, 2019
@hmoreras @fmontes
dotCMS/core#16792 Add friendly message when there are no rules (#1086)
7bd5884
@wezell
Copy link
Contributor Author

wezell commented Jul 12, 2019

image

@bryanboza
Copy link
Member

It would be nice to have a bit more friendliness, Right now we only have the message

@wezell
Copy link
Contributor Author

wezell commented Jul 12, 2019

Here is the mockup:

image

@wezell
Copy link
Contributor Author

wezell commented Jul 12, 2019

that white box should fill the screen or at least most of it
min-height: calc(100vh - 150px);

fmontes pushed a commit to dotCMS/core-web that referenced this issue Jul 15, 2019
@hmoreras @fmontes
dotCMS/core#16792 Style to match new mock
b6cd8a5
@fmontes
Copy link
Member

fmontes commented Jul 16, 2019 •
edited
Loading

We have rules for pages and for site...

For sites (the one we get from Marketing > Rules)

Screen Shot 2019-07-16 at 12 42 53 PM

For page (the one we get from the button in the edit page)

Screen Shot 2019-07-16 at 12 44 28 PM

Replace button

Screen Shot 2019-07-16 at 12 46 55 PM

fmontes pushed a commit to dotCMS/core-web that referenced this issue Jul 18, 2019
@hmoreras @fmontes
dotCMS/core#16792 Fix height in edit page rules and add different mes…
262adf0 
…sage for page and site rules
fmontes pushed a commit that referenced this issue Jul 18, 2019
@hmoreras @fmontes
#16792 Add friendly message when there are no rules (#16884)
f55cbb6
fmontes pushed a commit that referenced this issue Jul 22, 2019
@hmoreras @fmontes
#16792 Show page rule messages only in page
84f7f8d
fmontes pushed a commit to dotCMS/core-web that referenced this issue Jul 22, 2019
@hmoreras @fmontes
dotCMS/core#16792 Show page message rule only in pages
b3b1209
@bryanboza
Copy link
Member

Fixed , tested on master // Postgres // FF

@fmontes fmontes closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmoreras hmoreras

Labels
Doc : Needs Translation QA : Approved QA : Passed Internal Release : 5.2.0 Type : Enhancement
Projects
None yet
Milestone
5.1.6_07222019_FOX
Development

No branches or pull requests
4 participants
@fmontes @wezell @bryanboza @hmoreras