Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TinyMCE does not allow for images to be selected #17731

Closed
wezell opened this issue Dec 11, 2019 · 8 comments
Closed

TinyMCE does not allow for images to be selected #17731

wezell opened this issue Dec 11, 2019 · 8 comments
Labels
Changelog: Needs Doc Merged QA : Approved QA : Passed Internal Release : 5.2.3 Type : Defect

Comments

@wezell
Copy link
Contributor

wezell commented Dec 11, 2019

Long standing issue in TinyMCE - experienced by all CMSes that used TinyMCE as their editor:

tinymce/tinymce#3611
silverstripe/silverstripe-framework#6900
Wordpress, etc...

Upgrading tinymce fixes the issue - see mp4 attached

tinymce-bug.zip
wezell added a commit that referenced this issue Dec 11, 2019
@wezell
#17731 updated to latest tinymce
cfffbb9
@wezell wezell added this to the Bug Sprint milestone Dec 11, 2019
@fmontes fmontes modified the milestones: Bug Sprint, Lunik Current Dec 11, 2019
@wezell wezell modified the milestones: Lunik Current, Bug Sprint Dec 18, 2019
@wezell
Copy link
Contributor Author

wezell commented Dec 18, 2019

PR: #17733

dsilvam pushed a commit that referenced this issue Dec 19, 2019
@wezell @dsilvam
#17731 updated to latest tinymce (#17733)
d43edc9
@dsilvam dsilvam added the Merged label Dec 19, 2019
@dsilvam dsilvam self-assigned this Dec 19, 2019
@dsilvam dsilvam removed their assignment Dec 19, 2019
@dsilvam
Copy link
Contributor

dsilvam commented Dec 19, 2019

Passed Internal QA: Able to select the image and modify the different properties.

dsilvam pushed a commit that referenced this issue Dec 19, 2019
@wezell @dsilvam
#17731 updated to latest tinymce (#17733)
3fa5620
dsilvam pushed a commit that referenced this issue Dec 19, 2019
@wezell @dsilvam
#17731 updated to latest tinymce (#17733)
285d6ed
dsilvam added a commit that referenced this issue Dec 27, 2019
@dsilvam
Revert "#17731 updated to latest tinymce (#17733)"
504f1a9 
This reverts commit d43edc9.
dsilvam pushed a commit that referenced this issue Dec 27, 2019
@wezell @dsilvam
#17731 updated to latest tinymce (#17733)
21620f9
@bryanboza
Copy link
Member

We have an error trying to upload a new image to this editor.

To reproduce:

  • In the editor try to add a new image
  • Select some image file
  • Cancel the process
  • Try to upload again

tinyMCE

@wezell
Copy link
Contributor Author

wezell commented Jan 3, 2020

@john-thomas-dotcms this upgrades tinyMCE to version 4.9.6, the latest of the 4 series. Customers with custom tinyMCE plugins and configurations should validate that they work in this version.

@bryanboza bryanboza mentioned this issue Jan 3, 2020
Closed
@bryanboza
Copy link
Member

The error reported was moved to a new card (#17781 ). This will pass QA for now

@bryanboza
Copy link
Member

We have another problem after this upgrade,

wezell added a commit that referenced this issue Jan 3, 2020
@wezell
#17731 fixes switching issue
e1811af
wezell added a commit that referenced this issue Jan 3, 2020
@wezell
#17731 fixes switching issue
e072750
@wezell
Copy link
Contributor Author

wezell commented Jan 3, 2020 •
edited by dsilvam
Loading

PR: #17787

dsilvam pushed a commit that referenced this issue Jan 3, 2020
@wezell @dsilvam
Issue 17731 tinymce (#17786)
367cf23 
* #17731 fixes switching issue

* #17731 fixes switching issue
wezell added a commit that referenced this issue Jan 3, 2020
@wezell
#17731 cleans plugins more
8ea222c
wezell added a commit that referenced this issue Jan 3, 2020
@wezell
#17731 fixes switching issue
dd92104
wezell added a commit that referenced this issue Jan 3, 2020
@wezell
#17731 fixes switching issue
fc228d4
wezell added a commit that referenced this issue Jan 3, 2020
@wezell
#17731 cleans plugins more
4ed2144
dsilvam pushed a commit that referenced this issue Jan 3, 2020
@wezell @dsilvam
Issue 17731 tinymce master (#17787)
548d80a 
* #17731 fixes switching issue

* #17731 fixes switching issue

* #17731 cleans plugins more
@bryanboza
Copy link
Member

Fixed, tested on release-5.2.3 // Postgres // FF

@wezell wezell closed this as completed Jan 6, 2020
dsilvam pushed a commit that referenced this issue Feb 20, 2020
@wezell @dsilvam
Issue 17731 tinymce master (#17787)
10cf0dc 
* #17731 fixes switching issue

* #17731 fixes switching issue

* #17731 cleans plugins more
dsilvam pushed a commit that referenced this issue Feb 20, 2020
@wezell @dsilvam
Issue 17731 tinymce master (#17787)
77d48b0 
* #17731 fixes switching issue

* #17731 fixes switching issue

* #17731 cleans plugins more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Changelog: Needs Doc Merged QA : Approved QA : Passed Internal Release : 5.2.3 Type : Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fmontes @wezell @dsilvam @bryanboza