Issue 18780 container error using templates from different sites #19122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddyucv
commented
Aug 18, 2020
•
freddyucv
commented
- Always save absolute path to drawed template
- When copy a site change the path from the original site to the new site as long as the copy containers option is checked
- Update all the relative path to absolute in advanced template with a update task
…er_error_using_templates_from_different_sites
dsilvam
reviewed
Aug 25, 2020
| contMap.put("path", | ||
| FileAssetContainerUtil.getInstance() | ||
| .getFullPath(FileAssetContainer.class.cast(container)) | ||
| ); | ||
| } | ||
|
|
||
| // StringBuffer containerCode = new StringBuffer( cont.getCode() ); |
There was a problem hiding this comment.
done dotCMS/src/main/java/com/dotmarketing/util/TaskLocatorUtil.java
dsilvam
reviewed
Aug 25, 2020
| @@ -67,6 +67,9 @@ | |||
| */ | |||
| List<Container> findContainers(User user, boolean includeArchived, Map<String,Object> params, String hostId, String inode, String identifier, String parent, int offset, int limit, String orderBy) throws DotSecurityException, DotDataException; | |||
|
|
|||
| Container getContainerByFolderPath(String path, Host host, User user, boolean live, | |||
There was a problem hiding this comment.
dsilvam
reviewed
Aug 25, 2020
| } | ||
|
|
||
| @JsonIgnore | ||
| @NotNull |
There was a problem hiding this comment.
dsilvam
reviewed
Aug 25, 2020
| .anyMatch(containerUUID -> | ||
| containerUUID.getIdentifier().equals(identifier) && isTheSameUUID(containerUUID.getUUID(), uuid) | ||
| ); | ||
| public boolean existsContainer(final Container container, final String uuid){ |
There was a problem hiding this comment.
dsilvam
reviewed
Aug 25, 2020
| @@ -282,6 +282,7 @@ public static void removeFixTask(Class<?> clazz){ | |||
| .add(Task05300UpdateIndexNameLength.class) | |||
| .add(Task05305AddPushPublishFilterColumn.class) | |||
| .add(Task05350AddDotSaltClusterColumn.class) | |||
| .add(Task05370ChangeContainerPathToAbsolute.class) | |||
There was a problem hiding this comment.
put at the end and naming according to the last task
There was a problem hiding this comment.
|
UT Naming convention https://auth.dotcms.com/devwiki/upgrade-task-convention |
erickgonzalez
approved these changes
Aug 26, 2020
dsilvam
approved these changes
Sep 1, 2020
delete-merged-branch
bot
deleted the
issue_18780_Container_error_using_templates_from_different_sites
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.