Block editor freeze scroll on tippy menus show #23977
Assignees
Labels
Milestone
Comments
fmontes
added
Release : 23.03
Triage
OKR : Core Features
fmontes
changed the title
rjvelazco
added a commit
that referenced
this issue
Feb 22, 2023
fmontes
pushed a commit
that referenced
this issue
Feb 24, 2023
fmontes
added a commit
that referenced
this issue
Feb 28, 2023
* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 23.03, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-23.03 * Update branch in git submodule to release-23.03 * Excluding from triggering test at folder: dotCMS/src/main/webapp/html * #23977 Block editor freeze scroll on tippy menus show (#24180) * dev: freeze scroll on show forms #23977 * clean up * refactor * clean up v2 * feedback * clean up * Update .github/workflows/release-process.yml Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * Update .gitmodules Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * Update core-web/package.json Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * Update dotCMS/gradle.properties Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> --------- Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
|
Approved QA - Tested on 23.03_5ce847f3_SNAPSHOT // Docker // macOS 13.0 // FF v110.0 |
fmontes
added a commit
that referenced
this issue
Mar 6, 2023
* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 23.03, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-23.03 * Update branch in git submodule to release-23.03 * Excluding from triggering test at folder: dotCMS/src/main/webapp/html * #23977 Block editor freeze scroll on tippy menus show (#24180) * dev: freeze scroll on show forms #23977 * clean up * refactor * clean up v2 * feedback * clean up * #24172 Refresh Page portlet's data when site changed (#24175) * #24031 fix block editor not saving (#24222) * Fix #24032 Bring it to 22.03 (#24229) * Fix #24032 Bring it to 22.03 * Build de lib --------- Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> * #24240 Fix data-access tests in 23.03 (#24244) * #24240 fix test cases * #24240 fix lint * fire release docker image generation * #24221 fix Snapshots should be displayed when the language is changed (#24234) * Fix #23449 show dotAssets in folder listing * Fixing merge conflict in * Merging conflicts * Merging conflicts --------- Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: alfredo-dotcms <37185433+alfredo-dotcms@users.noreply.github.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com> Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com>
fmontes
added a commit
that referenced
this issue
Mar 9, 2023
* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 23.03, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-23.03 * Update branch in git submodule to release-23.03 * Excluding from triggering test at folder: dotCMS/src/main/webapp/html * #23977 Block editor freeze scroll on tippy menus show (#24180) * dev: freeze scroll on show forms #23977 * clean up * refactor * clean up v2 * feedback * clean up * #24172 Refresh Page portlet's data when site changed (#24175) * #24031 fix block editor not saving (#24222) * Fix #24032 Bring it to 22.03 (#24229) * Fix #24032 Bring it to 22.03 * Build de lib --------- Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> * #24240 Fix data-access tests in 23.03 (#24244) * #24240 fix test cases * #24240 fix lint * fire release docker image generation * #24221 fix Snapshots should be displayed when the language is changed (#24234) * Fix #23449 show dotAssets in folder listing * Bock Editor: Allow user to insert videos from local files#23863 (#24248) * dev: remove fileSize limit and fit the video in the block editor #23863 * clean up * Fix 24032: Adding for Internal QA (#24255) * #24032 Adding Fix for Internal QA * #24032 Adding PR Feedback * #24032 Adding PR Feedback * #24032 Adding PR Feedback * #24032 Logging error * dotCMS/core#issue-20432 adding const * dotCMS/core#issue-20432 adding const * #24032 validation schema * Adding empty extensions * Adding empty extensions * Get all modules no actions required * Adding optional validation for actions * Adding optional validation for actions * Adding id insted of name * Adding Type for promise * Adding dot-cms-block-editor * Adding lock file --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * #22151 make the message better (#24041) * #22151 make the message better * #22151 hides token button if aws * #24173 Create dialog for 'Create Page' button (#24215) * #24173 Create dialog for 'Create Page' button * #24173 Create dialog for 'Create Page' button - tests * #24173 Create dialog for 'Create Page' button - feedback * #24173 Create dialog for 'Create Page' button - more feedback * #23901 fixes the git hash resolution (#23902) * #23889 fixed content permission load issue (#24296) * #24308 Can't search for contentlets in edit page palette (#24316) * #24308 fixed contentlets search * #24308 refactor test case * #24308 refactor code * Update package-lock * Fix versioning * Fix versioning and FE tests * Build * Add line * Had to dedupe because some internal pck upgrade nx bin --------- Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: alfredo-dotcms <37185433+alfredo-dotcms@users.noreply.github.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com> Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com> Co-authored-by: Will Ezell <will@dotcms.com>
nollymar
pushed a commit
that referenced
this issue
Mar 15, 2023
* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 23.03, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-23.03 * Update branch in git submodule to release-23.03 * Excluding from triggering test at folder: dotCMS/src/main/webapp/html * #23977 Block editor freeze scroll on tippy menus show (#24180) * dev: freeze scroll on show forms #23977 * clean up * refactor * clean up v2 * feedback * clean up * #24172 Refresh Page portlet's data when site changed (#24175) * #24031 fix block editor not saving (#24222) * Fix #24032 Bring it to 22.03 (#24229) * Fix #24032 Bring it to 22.03 * Build de lib --------- Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> * #24240 Fix data-access tests in 23.03 (#24244) * #24240 fix test cases * #24240 fix lint * fire release docker image generation * #24221 fix Snapshots should be displayed when the language is changed (#24234) * Fix #23449 show dotAssets in folder listing * Bugs fixed: - When I search by URL I need to type exactly the full url to get a match - If I edit a page using right click and save it, the new changes aren't always displayed in the table and the context menu doesn't list the options correctly * Bock Editor: Allow user to insert videos from local files#23863 (#24248) * dev: remove fileSize limit and fit the video in the block editor #23863 * clean up * Fix 24032: Adding for Internal QA (#24255) * #24032 Adding Fix for Internal QA * #24032 Adding PR Feedback * #24032 Adding PR Feedback * #24032 Adding PR Feedback * #24032 Logging error * dotCMS/core#issue-20432 adding const * dotCMS/core#issue-20432 adding const * #24032 validation schema * Adding empty extensions * Adding empty extensions * Get all modules no actions required * Adding optional validation for actions * Adding optional validation for actions * Adding id insted of name * Adding Type for promise * Adding dot-cms-block-editor * Adding lock file --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * #22151 make the message better (#24041) * #22151 make the message better * #22151 hides token button if aws * #24173 Create dialog for 'Create Page' button (#24215) * #24173 Create dialog for 'Create Page' button * #24173 Create dialog for 'Create Page' button - tests * #24173 Create dialog for 'Create Page' button - feedback * #24173 Create dialog for 'Create Page' button - more feedback * #23792 feedback * #23792 More Feedback * #23792 More Feedback - unit tests * #23792 More Feedback v2 --------- Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com> Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com> Co-authored-by: Will Ezell <will@dotcms.com>
fmontes
added a commit
that referenced
this issue
Mar 28, 2023
* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 23.03, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-23.03 * Update branch in git submodule to release-23.03 * Excluding from triggering test at folder: dotCMS/src/main/webapp/html * #23977 Block editor freeze scroll on tippy menus show (#24180) * dev: freeze scroll on show forms #23977 * clean up * refactor * clean up v2 * feedback * clean up * #24172 Refresh Page portlet's data when site changed (#24175) * #24031 fix block editor not saving (#24222) * Fix #24032 Bring it to 22.03 (#24229) * Fix #24032 Bring it to 22.03 * Build de lib --------- Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> * #24240 Fix data-access tests in 23.03 (#24244) * #24240 fix test cases * #24240 fix lint * fire release docker image generation * #24221 fix Snapshots should be displayed when the language is changed (#24234) * Fix #23449 show dotAssets in folder listing * Bock Editor: Allow user to insert videos from local files#23863 (#24248) * dev: remove fileSize limit and fit the video in the block editor #23863 * clean up * Fix 24032: Adding for Internal QA (#24255) * #24032 Adding Fix for Internal QA * #24032 Adding PR Feedback * #24032 Adding PR Feedback * #24032 Adding PR Feedback * #24032 Logging error * dotCMS/core#issue-20432 adding const * dotCMS/core#issue-20432 adding const * #24032 validation schema * Adding empty extensions * Adding empty extensions * Get all modules no actions required * Adding optional validation for actions * Adding optional validation for actions * Adding id insted of name * Adding Type for promise * Adding dot-cms-block-editor * Adding lock file --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * #22151 make the message better (#24041) * #22151 make the message better * #22151 hides token button if aws * #24173 Create dialog for 'Create Page' button (#24215) * #24173 Create dialog for 'Create Page' button * #24173 Create dialog for 'Create Page' button - tests * #24173 Create dialog for 'Create Page' button - feedback * #24173 Create dialog for 'Create Page' button - more feedback * #23901 fixes the git hash resolution (#23902) * #23889 fixed content permission load issue (#24296) * #24308 Can't search for contentlets in edit page palette (#24316) * #24308 fixed contentlets search * #24308 refactor test case * #24308 refactor code * #24243 fixed squash between hint icon and label (#24298) * dev: update block editor (#24323) * [Issue-23863]: Fix #23863 Max Dimensions for Videos and Images (#24338) * #23863 adding fix for max dimensions * Adding editor * Fix label --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * mockPrintWriter (#24352) * #24263 prevent empty save block editor field (#24342) * Fix #24230 Block editor markdown content with javascript code is breaking the app (#24359) * #24230 * #24230 clean up * #24230 moving logic to the JSP * [Issue 24370] block editor crashing with allowed blocks (#24375) * #24370 Fixing undefined this * #24370 Fixing undefined this * Fix #23863 block editor allow user to insert videos from local files fix size (#24374) * dev: prevent close form while uploading asset #23863 * fix: large videos preview * clean up * update block editor * feedback * dev: update dotcms-block-editor.js file * Block Editor: Allow users to insert videos from external sources#23861 (#24409) * dev: validate video url * dev: add video validation #23861 * clean up * fix merge conflicts * update dotcms-block-editor.js * dev: add support link to unknown errors * Update core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-external-asset/utils/index.ts * Update core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-external-asset/utils/index.ts * update dotcms-block-editor.js --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * Fix #24361 block editor code block should not show suggestions or placeholder (#24403) * #24361 Blocking suggestions and placeholder * #24361 Blocking suggestions and placeholder * #24361 Blocking suggestions and placeholder * #24361 Blocking suggestions and placeholder * build file --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * #24422 fixes render * Update LTS check * Fix #23863 let user cancel upload (#24417) * dev: let user cancel upload #23863 * update dotcms-block-editor.js * clean up * feedback * update dotcms-block-editor.js * dev: upload automatically after selecting the video * Fix #24263: get the correct input element for block editor (#24429) * Fix #23449 Filter does not work on the image selector for image fields * Moved code to a new branch * Fix for the DB query * Fixed failing ITs also addressed the PR feedback * Added javadoc * Fixed the failing test * Fixed some ITs * Fix postman tests * Fixed postman tests * Addressed PR feedback * Making sonar happy * Adding more code changes. * Removed unnecessary file * Fixed luceneQuery to fix failing ITs * Adding `showOnMenu` term to lucene query. * Updating reindex policy in Integration Test to wait for the ES reindex to be done when saving the test files. * Adding temporary logging to the Integration Test * Force indexation. * Print more info. * Removing `SYSTEM_HOST` from DB query. * Fixing Integration Test. --------- Co-authored-by: Jose Castro <jose.castro@dotcms.com> * Fix #24299 now the get dependencies do not throw an exception when the story block value is not a json (#24439) * Bock Editor: Allow user to insert videos from local files #23863 (#24451) * dev: support video file and dotAsset #23863 * update dotcms-block-editor.js file * dev: update label to Library and dotcms-block-editor.js file * Block editor value [Object, object] fix (#24474) * Updating branch references * dev: rename video node (#24477) * dev: restore data mock time (#24478) * Fix conflict * Fix lock * Point to master * Fix lock * Fixing merging conflict. --------- Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: alfredo-dotcms <37185433+alfredo-dotcms@users.noreply.github.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com> Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com> Co-authored-by: Will Ezell <will@dotcms.com> Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com> Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User Story
As a user, I don't want to lose the focus by accidental scrolling while I am selecting blocks to insert in the editor.
Acceptance Criteria
Proposed Objective
Core Features
Proposed Priority
Priority 3 - Average
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
No response
Assumptions & Initiation Needs
Not including the tippy from the bar:
Only the suggestion
Sub-Tasks & Estimates
No response
The text was updated successfully, but these errors were encountered: