Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build New Search Engine Results Page Preview Tool for Google #25290

Closed
Tracked by #24862
damen-dotcms opened this issue Jun 20, 2023 · 9 comments · Fixed by #25848 or #26067
Closed
Tracked by #24862

Build New Search Engine Results Page Preview Tool for Google #25290

damen-dotcms opened this issue Jun 20, 2023 · 9 comments · Fixed by #25848 or #26067

Comments

@damen-dotcms
Copy link
Contributor

damen-dotcms commented Jun 20, 2023

Parent Issue

No response

Task

Build New Search Engine Results Page Preview Tool for Google

Proposed Objective

Same as Parent Issue

Proposed Priority

Same as Parent Issue

Acceptance Criteria

See notes here:

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Demo - https://www.figma.com/proto/jyu7b1wgL16iV7yOoNdgu9/SEO?page-id=1%3A65&type=design&node-id=298-6800&viewport=-1440%2C-118%2C0.37&scaling=scale-down&starting-point-node-id=372%3A9190

Design - https://www.figma.com/file/jyu7b1wgL16iV7yOoNdgu9/SEO?type=design&node-id=523-11475&t=URNtP1TkxmYhhpH9-0

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

manuelrojas added a commit that referenced this issue Aug 16, 2023
manuelrojas added a commit that referenced this issue Aug 16, 2023
manuelrojas added a commit that referenced this issue Aug 18, 2023
manuelrojas added a commit that referenced this issue Aug 18, 2023
manuelrojas added a commit that referenced this issue Aug 22, 2023
manuelrojas added a commit that referenced this issue Aug 22, 2023
manuelrojas added a commit that referenced this issue Aug 22, 2023
manuelrojas added a commit that referenced this issue Aug 22, 2023
manuelrojas added a commit that referenced this issue Aug 22, 2023
manuelrojas added a commit that referenced this issue Aug 22, 2023
manuelrojas added a commit that referenced this issue Aug 22, 2023
manuelrojas added a commit that referenced this issue Aug 22, 2023
manuelrojas added a commit that referenced this issue Aug 22, 2023
manuelrojas added a commit that referenced this issue Aug 23, 2023
manuelrojas added a commit that referenced this issue Aug 23, 2023
manuelrojas added a commit that referenced this issue Aug 23, 2023
manuelrojas added a commit that referenced this issue Aug 23, 2023
manuelrojas added a commit that referenced this issue Aug 23, 2023
manuelrojas added a commit that referenced this issue Aug 23, 2023
@dcolina
Copy link
Contributor

dcolina commented Oct 2, 2023

Internal QA: Needs work.

Favicon

Case 1:

When Favicon not found!

The expected message `Favicon not found! is missing.

Image

Case 2:

When Favicon exists, but it has an invalid link.

The expected message Favicon found, but Image Link is not valid! is missing.

Image

Title

Case 1:

When HTML Title not found!

The expected message HTML Title not found! is missing.

Image

Case 2:

When the HTML Title is empty.

<title></title>

The expected message HTML Title found, but is empty does not match.

Image

Description

Case 1:

When Meta Description is missing.

The expected message Meta Description not found! is missing.

Image

Case 2:

When Meta Description is duplicated.

<meta name="description" content="Hello world and It has enough characters to show." />
<meta name="description" content="Hello world and It has enough characters to show." />

The expected message More than 1 Meta Description found! does not match.

Image

Case 3:

When Meta Description exists, but is empty.

<meta name="description" />
The expected message Meta Description found, but is empty! is missing.

Image

Case 4:

When Meta Description exists, and it has more than 160 characters.

```

The expected message Meta Description found, but it has more than 160 characters. does not match.

Case 5:

When Meta Description exists, and it has less than 55 characters.

The expected message Meta Description found, but it has fewer than 55 characters of content. does not match.

Image

Case 6:

When Meta Description exists, and it has between 55 and 160 characters of content.

The expected message Meta Description found!

Image

@manuelrojas
Copy link
Contributor

manuelrojas commented Oct 3, 2023

@dcolina There is another task for this:

Case 2:

When Favicon exists, but it has an invalid link.

The expected message Favicon found, but Image Link is not valid! is missing.

@nollymar
Copy link
Contributor

nollymar commented Oct 9, 2023

The other issues have been fixed on #26388

@dcolina
Copy link
Contributor

dcolina commented Oct 13, 2023

Internal QA: Needs work.

Favicon

Case 1:

When meta tag is found, but is empty.

<link rel="icon" />

The expected message Favicon not found, but Image Link is not valid! does not match.

Screenshot 2023-10-13 at 10 40 57

Description

Case 1:

When meta tag exists, and it has between 55 and 160 characters.

<meta name="description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla pharetra maximus enim ac tincidunt. Vivamus vestibulum sed enim sed consectetur." />

The expected message Meta Description found! does not match.

Screenshot 2023-10-13 at 10 47 07

Case 2:

When meta tag exists, and it has more than 160 characters.

<meta name="description" content="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla pharetra maximus enim ac tincidunt. Vivamus vestibulum sed enim sed consectetur. Nulla malesuada libero a tristique bibendum. Suspendisse blandit ligula velit, eu volutpat arcu ornare sed." />

The expected message Meta Description found, but it has more than 160 characters. does not match. And preview has the wrong length, it has 159 characters when it must be 160.

Screenshot 2023-10-13 at 10 53 58

@manuelrojas
Copy link
Contributor

manuelrojas commented Oct 17, 2023

@dcolina I noticed that is showing the 159 characters because the last character is an empty space so when pushing into the HTML it trims the value.

@dcolina
Copy link
Contributor

dcolina commented Oct 19, 2023

Internal QA: Needs work.

HTML Title

Case 1:

When Title length = 30 characters.

<title>HTML TITLE -------------- TEST</title>

The expected message HTML Title found, with an appropriate amount of content! does not match.

Image

Case 2:

When Title length = 60 characters.

<title>HTML TITLE -------------- TEST******************************</title>

The expected message HTML Title found, with an appropriate amount of content! does not match.

Image

HTML Description

Case 1:

When Description length = 55 characters.

<meta name="description" content="DESCRIPTION ****TEST.Lorem ipsum dolor sit amet.-------" />

The expected message Meta Description found! does not match.

Image

Case 2:

When Description length = 160 characters.

<meta name="description" content="DESCRIPTION ****TEST.Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis ante metus, posuere quis posuere eu, varius nec ante. Aenean nec dictum purus" />

The expected message Meta Description found! does not match.

Image

@dcolina dcolina removed their assignment Oct 19, 2023
@manuelrojas manuelrojas assigned dcolina and unassigned manuelrojas Oct 23, 2023
@dcolina
Copy link
Contributor

dcolina commented Oct 23, 2023

Internal QA: PASSED.

@dcolina dcolina removed their assignment Oct 23, 2023
@josemejias11
Copy link
Contributor

Approved: Tested on master_df4427b_SNAPSHOT, Docker, macOS 13.0, FF v113.0

Added card #26497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment