Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#24645 adding a fix to add permission for dot fav page #24712

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

jdotcms
Copy link
Contributor

@jdotcms jdotcms commented Apr 21, 2023

Adding permissions to the BE on dot fav

@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Unit Tests Report

1 431 tests  +1 431   1 421 ✔️ +1 421   3m 55s ⏱️ + 3m 55s
   141 suites +   141        10 💤 +     10 
   141 files   +   141          0 ±       0 

Results for commit 7b8f69d. ± Comparison against base commit 695984b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Postman Tests Report

     65 files   -     1  1 283 suites   - 137   3h 10m 26s ⏱️ - 23m 39s
   583 tests  -   45     580 ✔️  -   42  0 💤 ±0  3  - 3 
2 200 runs   - 157  2 196 ✔️  - 154  0 💤 ±0  4  - 3 

For more details on these failures, see this check.

Results for commit 7b8f69d. ± Comparison against base commit 695984b.

This pull request removes 45 tests.
GraphQl ‑ 'Containers Field' includes all Container Structures
GraphQl ‑ 'DotAssetBaseTypeCollection' includes all fields
GraphQl ‑ 'FileBaseTypeCollection' includes all fields
GraphQl ‑ 'KeyValueBaseTypeCollection' includes all fields
GraphQl ‑ 'Page' includes all properties
GraphQl ‑ 'PageBaseTypeCollection' includes all fields
GraphQl ‑ 'PersonaBaseTypeCollection' includes all fields
GraphQl ‑ 'QueryMetadata' includes all fields
GraphQl ‑ 'Site' element includes all properties
GraphQl ‑ 'VanityURLBaseTypeCollection' includes all fields
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Integration Tests [postgres] Report

   415 files  ±0     415 suites  ±0   1h 41m 46s ⏱️ -54s
3 989 tests ±0  3 961 ✔️  - 1  23 💤 ±0  5 +1 
4 008 runs  ±0  3 980 ✔️  - 1  23 💤 ±0  5 +1 

For more details on these failures, see this check.

Results for commit 7b8f69d. ± Comparison against base commit 695984b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Integration Tests [mssql] Report

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 2958eae. ± Comparison against base commit 695984b.

♻️ This comment has been updated with latest results.

Copy link

@freddyucv freddyucv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any test?

@jdotcms jdotcms closed this Apr 25, 2023
@jdotcms jdotcms reopened this Apr 25, 2023
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@fmontes fmontes enabled auto-merge (squash) April 26, 2023 16:31
@fmontes fmontes disabled auto-merge April 26, 2023 18:50
@fmontes fmontes merged commit 88304cb into master Apr 26, 2023
@fmontes fmontes deleted the issue-24645-pages branch April 26, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants