Issue-24918: Favorite pages: print the error message from the HTML2Canvas lib to the console #24936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-error-message-from-the-html2canvas-lib-to-the-console
AndreyDotcms
approved these changes
May 15, 2023
rjvelazco
approved these changes
May 15, 2023
...i/src/app/portlets/dot-edit-page/components/dot-favorite-page/dot-favorite-page.component.ts
Show resolved
Hide resolved
zJaaal
approved these changes
May 15, 2023
alfredo-dotcms
approved these changes
May 15, 2023
manuelrojas
requested review from
alfredo-dotcms,
rjvelazco,
zJaaal and
AndreyDotcms
…e-error-message-from-the-html2canvas-lib-to-the-console
zJaaal
approved these changes
May 16, 2023
fmontes
approved these changes
May 17, 2023
|
SonarQube Quality Gate
|
| @@ -34,6 +36,8 @@ export class DotHtmlToImage { | |||
| }).then((canvas) => { | |||
| canvas.toBlob((blob) => { | |||
| const fileObj = new File([blob], 'image.png'); | |||
| const iframe = parent.document.querySelector('#${this.iframeId}'); | |||
There was a problem hiding this comment.
can you check if this shouldn't be a be a backtick, instead of a single quote?
const iframe = parent.document.querySelector(`#${this.iframeId}`);
also on lines 42 and 49
There was a problem hiding this comment.
It's been generated correctly:
alfredo-dotcms
approved these changes
May 18, 2023
fmontes
deleted the
issue-24918-favorite-pages-print-the-error-message-from-the-html2canvas-lib-to-the-console
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
🤖 Generated by Copilot at 2550ba3
Improved the functionality and appearance of the
dot-favorite-pagecomponent and thedot-html-to-imagecomponent. Fixed an unused import and added error handling in the former, and enhanced iframe loading and rendering in the latter. Adjusted the height and position of the components to avoid extra space and overlapping.Checklist
Additional Info
** any additional useful context or info **
Screenshots
Screen.Recording.2023-05-17.at.5.41.14.PM.mov
Screen.Recording.2023-05-17.at.5.42.27.PM.mov