Fix #25678: Allow editing of contentlet on detail page #26032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nhance readability
…andle feature flag
…dorpdown were off
zJaaal
requested review from
manuelrojas,
hmoreras,
oidacra,
fmontes,
rjvelazco and
KevinDavilaDotCMS
fmontes
requested changes
Sep 21, 2023
...t/components/dot-edit-page-state-controller/dot-edit-page-state-controller.component.spec.ts
Show resolved
Hide resolved
...ontent/components/dot-edit-page-state-controller/dot-edit-page-state-controller.component.ts
Outdated
Show resolved
Hide resolved
...ontent/components/dot-edit-page-state-controller/dot-edit-page-state-controller.component.ts
Outdated
Show resolved
Hide resolved
...ents/dot-edit-page-state-controller-seo/dot-edit-page-state-controller-seo.component.spec.ts
Outdated
Show resolved
Hide resolved
...ents/dot-edit-page-state-controller-seo/dot-edit-page-state-controller-seo.component.spec.ts
Outdated
Show resolved
Hide resolved
...ents/dot-edit-page-state-controller-seo/dot-edit-page-state-controller-seo.component.spec.ts
Show resolved
Hide resolved
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.spec.ts
Outdated
Show resolved
Hide resolved
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.spec.ts
Show resolved
Hide resolved
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.spec.ts
Outdated
Show resolved
Hide resolved
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.ts
Outdated
Show resolved
Hide resolved
rjvelazco
previously requested changes
Sep 21, 2023
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.ts
Outdated
Show resolved
Hide resolved
...ontent/components/dot-edit-page-state-controller/dot-edit-page-state-controller.component.ts
Outdated
Show resolved
Hide resolved
...omponents/dot-edit-page-state-controller-seo/dot-edit-page-state-controller-seo.component.ts
Show resolved
Hide resolved
...omponents/dot-edit-page-state-controller-seo/dot-edit-page-state-controller-seo.component.ts
Outdated
Show resolved
Hide resolved
fmontes
approved these changes
Sep 22, 2023
fmontes
dismissed
rjvelazco’s stale review
Talked thought and decide against.
rjvelazco
approved these changes
Sep 22, 2023
auto-merge was automatically disabled
September 22, 2023 15:37
Base branch was modified
|
SonarQube Quality Gate
|
|
SonarQube Quality Gate
|
fmontes
deleted the
25678-allow-editing-of-contentlet-on-detail-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 6269d5e
Summary
🐛🚀🧪
This pull request adds the feature of editing URL content map from the edit page state controller and the SEO component. It updates the
DotTabButtonsComponentto handle dynamic options and improve the dropdowns functionality. It also adds tests, interfaces, and feature flags for the new feature and fixes some minor issues in the code.Walkthrough
addTwoNumbersfunction to use addition instead of subtraction (link)DotEditPageStateControllerComponentandDotEditPageStateControllerSeoComponent(link, link, link, link, link, link, link, link, link, link, link)p-menucomponent to display the menu for editing URL content map inDotEditPageStateControllerComponentandDotEditPageStateControllerSeoComponent(link, link, link, link, link, link, link, link, link, link, link, link)urlContentMapproperty ofDotPageRenderParametersinterface to includecontentTypeandinodeproperties (link)DotTabButtonsComponentto clone and update the options when they change and to toggle and reset the dropdowns icons accordingly (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)DotEditPageStateControllerComponentandDotEditPageStateControllerSeoComponentto useidproperty instead ofvalueproperty for the options and to includeshowDropdownButtonproperty (link, link, link, link, link, link, link, link, link, link, link, link)DotEditPageStateControllerComponentandDotEditPageStateControllerSeoComponentto mock the HTTP requests, theDotContentletEditorService, theDotPropertiesService, and theDotHttpErrorManagerService(link, link, link, link, link, link, link, link, link, link, link, link)DotEditPageStateControllerComponent(link, link, link)variantinput fromDotEditPageStateControllerComponentin the test host component (link)DotContentletEditorServiceas a provider for the test host component ofDotEditPageToolbarSeoComponent(link)modeinput ofDotTabButtonsComponentin the test host component to useactiveIdinput instead (link, link)Screenshots
Screen.Recording.2023-09-11.at.5.11.33.PM.mov