dotCMS/core#25901 Unable to reuse content inside the variants #26450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmoreras
requested review from
fmontes,
oidacra,
manuelrojas,
rjvelazco and
zJaaal
zJaaal
approved these changes
Oct 18, 2023
manuelrojas
approved these changes
Oct 18, 2023
oidacra
approved these changes
Oct 18, 2023
fmontes
previously requested changes
Oct 18, 2023
Comment on lines
40
to
42
| this.store.setLanguageId(languageId); | ||
| this.store.switchView(); | ||
| this.store.getContenttypesData(); |
There was a problem hiding this comment.
You can unify this in one updater because here you are updating the state 3 times and triggering changes 3 times.
There was a problem hiding this comment.
good catch thanks. done, at least a couple less.
|
SonarQube Quality Gate
|
fmontes
approved these changes
Oct 20, 2023
| */ | ||
| switchLanguage(languageId: string): void { | ||
| this.setLanguage(languageId); | ||
| this.getContenttypesData(); |
There was a problem hiding this comment.
What this method is doing doesn't look like something that belongs to a store, looks very very anti pattern.
dsolistorres
pushed a commit
that referenced
this pull request
Nov 6, 2023
* refresh the content palette when the languge change * make a couple of less state updates * clean up
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
* fix: add publish and unpublish date (#25233) * #25233 fixed exception handling for upgrade task test * fix(containers): Tabs and Rows Variables Height #26197 * Homolage containers tab to Content Type tabs * Now use color variables. Removed unused and unnecesary scss code-classes * Making look back window configurable (#26346) * Fixing bug when decide if create a Anonymous Template * Fixing error on DotPageRenderService * Making lookBackWindow configurable * Fixing test * #26332 Move `DotCopyButtonComponent` to UI lib (#26336) * 26332 move DotCopyButtonComponent to UI lib * #26332 fix lint * Issue 26348 dot content map is not working on containers (#26356) * Fixing bug when decide if create a Anonymous Template * Fixing error on DotPageRenderService * Removing dotContentMap from auto generated code * fix(ui) Add taglink css fix to source scss (#26365) * fix(ui): Table Header Sort Icon Misplacement #26366 * fix(ui) #26056: Autocomplete Styles were Off * fix (autocomplete styles): height and fonts were off for autocomplete without chips * feedback (autocomplete styles): add calculation to maintain the variables * fix(ui) Template last edit date column align (#26372) * fix(ui) Template last edit date column align * Fix test * fix(ui) Block Editor Input styles are not being applied #26370 * dev: generate file * dev: move dotCMS block editor script to parent file * #26373: Making CircuitBreakerUrl more informative about the errors when consuming an http endpoint (#26364) * ci(dev-cycle): moving postman tests to maven CI/CD pipeline workflow (#26291) Introducing postman tests and its dependencies to be started, ended and reported as the same way the other tests (unit and integration) do, that is by the maven CI-CD pipeline workflow. Refs: #25890 * feat(content cleanup) : Automatically prune File Asset versions exceeding a configurable limit #26188 (#26350) * fix(content cleanup) : Automatically prune File Asset versions exceeding a configurable limit #26188 * Implementing SonarQube feedback. * Implementing SonarQube feedback. * Fixing test class name. * fix(core): Referencing Tika JARs from Artifactory (#26027) * Temporary changes * Leave internal version as it is until the new versioning approaach is implemented * Leave internal version as it is until the new versioning approach is implemented --------- Co-authored-by: Will Ezell <will@dotcms.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * Fixing experiment pp bug (#26379) * Fixing bug when decide if create a Anonymous Template * Fixing error on DotPageRenderService * #25732 Fixing Bug when try to Push a Page Variant Version using the System Template * Fixing bug with thw Scheduling on PP * Fixing bug with thw Scheduling on PP * Comment test * Comment test * feat(edit-content) Allow user to upload files from external sources (fix #26313) * dev: add url mode * dev: create DotBinaryFieldUrlMode component * test: cover dotBinaryFieldUrlMode Component tests * dev: add i18n - internalization * dev: improve style & build binary field * dev: avoid closing the dialog while uploading * dev: add store for URL Mode * test: DotBinaryFieldUrlMode Component * dev: generate contenttype-fields-styles.css file * clean up * clean up v2 * feedback * clean up * feedback v1 * move fonts.scss to dotcms-scss/angular * feedback v3 * clean up * feeback: input & button styles * feeback: binart fiel css file * styles: fix error message height * clean up * feedback: button styles * dev: build binary field web-component * clean up * fix: frontend tests * clean up v2 * build web component --------- Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> * fix(containers) Tabs and Rows Variables Height #26197 * #26387 fix overwritten css (#26394) * [Internal-QA]: Fixes for social media seo (#26388) * #26262 Adding readmore styling * Merging with master * #25288 Internal QA feedback * #25288 Internal QA feedback * #25288 Adding twitter fixes * Adding the models * Adding more testing * feat(content cleanup) : Automatically prune File Asset versions exceeding a configurable limit #26188 (#26350) * fix(content cleanup) : Automatically prune File Asset versions exceeding a configurable limit #26188 * Implementing SonarQube feedback. * Implementing SonarQube feedback. * Fixing test class name. * fix(core): Referencing Tika JARs from Artifactory (#26027) * Temporary changes * Leave internal version as it is until the new versioning approaach is implemented * Leave internal version as it is until the new versioning approach is implemented --------- Co-authored-by: Will Ezell <will@dotcms.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * Fixing experiment pp bug (#26379) * Fixing bug when decide if create a Anonymous Template * Fixing error on DotPageRenderService * #25732 Fixing Bug when try to Push a Page Variant Version using the System Template * Fixing bug with thw Scheduling on PP * Fixing bug with thw Scheduling on PP * Comment test * Comment test * feat(edit-content) Allow user to upload files from external sources (fix #26313) * dev: add url mode * dev: create DotBinaryFieldUrlMode component * test: cover dotBinaryFieldUrlMode Component tests * dev: add i18n - internalization * dev: improve style & build binary field * dev: avoid closing the dialog while uploading * dev: add store for URL Mode * test: DotBinaryFieldUrlMode Component * dev: generate contenttype-fields-styles.css file * clean up * clean up v2 * feedback * clean up * feedback v1 * move fonts.scss to dotcms-scss/angular * feedback v3 * clean up * feeback: input & button styles * feeback: binart fiel css file * styles: fix error message height * clean up * feedback: button styles * dev: build binary field web-component * clean up * fix: frontend tests * clean up v2 * build web component --------- Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> * Adding more testing * Adding refactor * Adding refactor * Adding refactor * Adding refactor * Adding more refactor * Limit the preview * Adding preview in 60 characters * PR Feedback * PR Feedback * Adding PR feedback --------- Co-authored-by: Jose Castro <jose.castro@dotcms.com> Co-authored-by: Will Ezell <will@dotcms.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> Co-authored-by: Freddy Rodriguez <freddy0309@gmail.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> * chore(cli): Implement gha generate cli release (#26294) * #25951 Setting versions-maven-plugin for release version management. * #25951 Setting precheck job (checkout, java, git, set release version). * #25951 Setting Java version and Java distribution. * #25951 Getting input variables on release job. * #25951 Printing GitHub context. * #25951 Printing GitHub context REF. * #25951 Testing release version setup. * #25951 fixing release version setup. * #25951 fixing release version setup.+1. * #25951 fixing release version setup.+2. * #25951 fixing release version setup.+3. * 🏁 Releasing version 1.0.0 * #25951 Testing next version setup. * #25951 Fixing next version setup. * 🏁 Releasing version 1.1.0 * #25951 Fixing next version setup. +1. * #25951 Fixing next version setup. +2. * 🏁 Releasing version 1.2.0 * #25951 Fixing next version setup. +3. * #25951 Fixing next version setup. +4. * 🏁 Releasing version 1.3.0 * #25951 Fixing next version setup. +5. * #25951 Fixing next version setup. Adding git config. * 🏁 Releasing version 1.4.0 * #25951 Fixing next version setup. Check current branch out.+1. * #25951 Fixing next version setup. Check current branch out.+2. * 🏁 Releasing version 1.4.1 * #25951 Fixing next version setup. Check current branch out.+3. * 🏁 Releasing version 1.4.2 * ⬆️ Next version 1.0.0-SNAPSHOT * #25951 Testing build and releaser steps. * 🏁 Releasing version 1.4.0 * #25951 Build and releaser steps. Adding module in main pom file for testing. * #25951 Fixing build and releaser steps. +1. * 🏁 Releasing version 1.4.1 * #25951 Fixing releaser steps. +1. * #25951 Fixing releaser steps. +2. * 🏁 Releasing version 1.4.2 * ⬆️ Next version 1.0.0-SNAPSHOT * #25951 Testing deploy distribution on artifactory. * 🏁 Releasing version 1.4.3 * #25951 Fixing test deploy distribution on artifactory. +1. * 🏁 Releasing version 1.4.3 * #25951 Fixing test deploy distribution on artifactory. +2. * 🏁 Releasing version 1.4.3 * #25951 Fixing test deploy distribution on artifactory. +3. * 🏁 Releasing version 1.1.0-SNAPSHOT * ⬆️ Next version 1.0.0-SNAPSHOT * #25951 Testing JReleaser artifactory integration. * 🏁 Releasing version 1.2.3-SNAPSHOT * #25951 Testing JReleaser artifactory integration. +1. * 🏁 Releasing version 1.4.0-SNAPSHOT * ⬆️ Next version 1.0.0-SNAPSHOT * #25951 Testing JReleaser artifactory integration. +2. * #25951 Testing JReleaser artifactory integration. +3. * 🏁 Releasing version 1.0.0-SNAPSHOT * ⬆️ Next version 1.0.0-SNAPSHOT * #25951 Testing build step. * 🏁 Releasing version 1.0.0-SNAPSHOT * ⬆️ Next version 1.0.0-SNAPSHOT * #25951 Testing JReleaser artifactory integration, snapshot repository and release repository configuration. * 🏁 Releasing version 1.0.0-SNAPSHOT * ⬆️ Next version 1.0.0-SNAPSHOT * 🏁 Releasing version 1.0.0-SNAPSHOT * ⬆️ Next version 1.0.0-SNAPSHOT * 🏁 Releasing version 1.0.0-SNAPSHOT * dotcms-cli release generation. * 🏁 Releasing version 1.0.0-SNAPSHOT * #25951 dotcms-cli Release generation. +1. * 🏁 Releasing version 1.0.0-SNAPSHOT * Update cli-release-process.yml * 🏁 Releasing version 1.0.0-SNAPSHOT * ⬆️ Next version 1.0.0-SNAPSHOT * #25951 dotcms-cli Release generation. +2. * 🏁 Releasing version 1.0.0-SNAPSHOT * ⬆️ Next version 1.0.0-SNAPSHOT * #25951 Some improvements in the release process. * #25951 dotcms-cli pom files optimization. Pom parent (core) has been added. * 🏁 Releasing version 1.0.0-SNAPSHOT * Testing GHA cli release workflow * 🏁 Releasing version 1.0.0-SNAPSHOT * Fixing package distribution step. * 🏁 Releasing version 1.0.0-SNAPSHOT * Fixing package distribution step. +1. * 🏁 Releasing version 1.0.0-SNAPSHOT * Fixing package distribution step. +2. * Fixing cli release workflow. +3. * Fixing package distribution step. +3. * 🏁 Releasing version 1.0.0-SNAPSHOT * Fixing package distribution step. +4. * 🏁 Releasing version 1.0.0-SNAPSHOT * Fixing package distribution step. +5. * 🏁 Releasing version 1.0.0-SNAPSHOT * Fixing package distribution step. +6. * 🏁 Releasing version 1.0.0-SNAPSHOT * Fixing package distribution step. +7. * 🏁 Releasing version 1.0.0-SNAPSHOT * Fixing package distribution step. +8. * 🏁 Releasing version 1.0.0-SNAPSHOT * Fixing package distribution step. +9. * 🏁 Releasing version 1.0.0-SNAPSHOT * ⬆️ Next version 1.0.0-SNAPSHOT * #25951 Fixing parent pom (core) configuration. * #25951 Maven cache configuration updated. POM properties improvement. --------- Co-authored-by: daniel.colina <daniel.colina@dotcms.com> Co-authored-by: GitHub Actions <actions@github.com> * chore(cli): Implement GHA to execute a super push (#26334) * save point * save point * #26300 script improvements * #26300 fixes to the script that runs the cli * feat(containers): Add extra fields for code variables (fix #26293) * dev (dot add variable): add extra fields for image * dev (dot add variable): small clean up * copywritting (dot add variables store): fix comment * dev (dot add variables): enhance models and methods naming * dev (dot add variable): small cleanup * dev (dot add variable store): small clean up * dev (dot add variable): add missing test * feedback (dot add variable): small clean up * dev (general): add dot fields service to handle custom code and extra fields * fix (dot add variable module): add provider * dev (dot add variable models): filter fieldTypes that does not appear on legacy portlet * dev (dot fields service): add custom code for block editor and binary * dev (dot add fields service): add checkbox, radio, select and multiselect extra fields * fix (dot fields service): fix message * dev (dot fields service): add extra fields for date fields * dev (dot fields service): add test cases * fix (dot add variable test): broken test * dev (dot add variable component): styles clean up * dev (dot add variables): fix merge conflicts * dev (dot fields service): general code cleanup * fix (dot fields service): typo in fields variables * dev (dot fields service): fix custom code to match new variables * fix (dot add variable): broken test * dev (dot fields service): fix variables and custom code for dates * dev (dot container code): now editor replaces where the cursor selected or add where the cursor is * dev (dot container code component): enhance variable naming * fix (language properties): re add deleted key * dev (dot fields service): addressing changes requested in the PO * Issue 26400 generate runningid when scheduling (#26404) * #26400 generate runningid when scheduling Experiment * #26400 IT * #26400 rewrite IT * #26403 Fixing language properties (#26406) * fix(seo improvements): copy change for google serp preview (#26410) * #26403 Fixing language properties * #26402 Change google, fix facebook labels * PR Feedback * Adding testing for result components * Adding few more tests * #26402 Adding test for meta tags * #26402 Adding test for meta tags * #25732: fix on adding variant template dependecy when creating bundle (#26414) * More time metrics (#26398) * fix(core): Add a role extra layer constraint into the secrets view tool #25587 * Adding minor fixes reported via IQA feedback. * Using constants for characters * Implementing Code Review feedback. * Implementing SonarQube feedback. * #25901 Retrieve Contentlet created in Variant in the Palette Sidebar (#26338) * #25901 testing lucent query * Not include variant filter if the lucene query already is filtering by variant * Sending Variant attribute * #25901 handle the variant field * #25901 remove the default duplicated contentlet in a variant * #25901 fix comments * #25901 fix comments * #25901 fix comments * fix test --------- Co-authored-by: freddyucv <freddy0309@gmail.com> * fix(container): Add max height and overflow behavior to menu component (#26442) * fix(ui) #26435: Dojo Dropdown Options broken on search (#26436) * dev (dojo menu styles): encapsulate template selector styles * dev (dojo menu styles): add font weight bold to highlight match * feat(edit-content): Allow User To Create A By Write Code #26045 * dev: add monaco editor in dojo * clean up * feat(edit-content) Develop basic form with text field and save button #26330 * Working on EditContenlet MVP * Maked changes based on PR suggestions * Finalized new arch of edit-content lib. * Working on PR Suggestions * Working on tests. Have problem on edit-content.layout.spec * Find issue in tests * Finished tests * Make a PR suggestion changes. Added new tests * Maked PR suggestions. Added new tests. Added new behavior on content-edit.layout * Changed way to test dot-edit-content.service, now use createHttpFactory * Remove unused imports and variables * Add sidebar and styles rows spacing --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> * #26146 force width in inline input dropdown (#26429) * fix(add-to-bundle): force width in inline input dropdown * fix(add-to-bundle): force width in inline input dropdown globally * feat(edit-content) Show block/wysiwyg/text fields editing full screen #26222 * feat(ui) show full screen when it is the only thing on the tab ref: #26222 * feat(ui) full screen for fields ref: #26222 * feat(ui) full screen fields it tests ref: #26222 * feat(ui) adding feature flag or as an env var ref: #26222 * dev (dotcms dojo styles): compile new styles for fullscreen mode * dev (dotcms styles): compile styles * dev (block editor general): add styles and functionality to fullscreen the block editor * dev (edit field): add fullscreen for wysiwyg and plain text * dev (edit field): add final functionality for wysiwyg * dev (edit field): delete console.log * Implementing SonarQube feedback. * dev (dotcms dojo styles): add comments --------- Co-authored-by: Will Ezell <will@dotcms.com> Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> Co-authored-by: Jose Castro <jose.castro@dotcms.com> * fix(containers): Tabs and Rows Variables Height #26197 * Fixed jumping on hover and wrapping text on tabs * Move css to tabview --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * Issue #26425: Support Multi lang when include MultiTree Contentlet inside a Bundle (#26438) * feat(core): Add a role extra layer constraint into the secrets view tool #25587 * Issue #25184: adding the support for the system table config (#25936) * #25184 adding the support for the system table config * #25184 adding the support for the system table config * #25184 avoid recursive issues on system table/config * #25184 adding fixes and unit test * #25184 adding fixes and unit test * #25184 adding feedback * #25184 adding more coverage test * #25184 trying some fixes for the init fail * #25184 reverting undesired changes * #25184 reverting undesired changes * #25184 reverting undesired changes * #25184 decoupling the task from config * #25184 trying to avoid issues when the db is no ready * #25184 trying to avoid issues when the db is no ready * #25184 adding a fix to avoid to run the system table on test * #25184 adding an event when update the system table * #25184 making lazy the system table on the config source * #25184 lazyness of the config dependency * Attempt to fix Integration Test run * Attempt to fix Integration Test run * Attempting to fix Unit Test run * Attempting to fix Unit Test run * Reverting unnecessary file changes. * Implementing SonarQube feedback * Merging changes from master. --------- Co-authored-by: Jose Castro <jose.castro@dotcms.com> * feat(edit-contentlet): Allow User Write Code #26045 * dev: add monao editor * dev: set monaco editor * dev: make editor cover space available * test: cover DottBinaryFieldEditorComponent test cases * dev: add type/mimeType validation * clean up * dev: build binary field and add validation message for file name * test: fix broken test * dev: hide old edit file on new binary field * Feedback: Freddy's suggestion * [Issue-25959]: seo improvements validate when favicon or preview image are broken (#26443) * Fixing facebook meta * Copy change * #25959 Fixing method to validate if the image does not exits * Progres on #25959 * #25959 Adding Progress on image broken * #25959 image not-found * #25959 Adding new component * #25959 adding preview component * #25959 Adding image broken * #25959 Adding image broken * #25959 Adding image broken * #25959 Css fixes' * #25959 Css fixes' * #25959 Fixing google validation * #25959 Added testing to the preview components * #25959 fix image not found * #25959 fix image not found * PR feedback * PR Feedback * Adding meta tags service * PR feedback * PR feedback * Fixing limit * save point (#26430) * save point * #26380 * #26380 this should fix the issue * #26380 * #26380 fix in pipiline + fix in Test * #26380 adjusting test to relflect fix * #26380 playing wiht broken test * debug info * testing more scenarios * #26380 trying fix for test * #26380 IT * #26380 undoing refactor saving it for anther PR * #26380 fixing doc * #26380 applying feedback provided * #26380 replacing Abstract Class by the concrete impl * feat(core): Add db layer to our config to allow on-the-fly (no restart) configuration #25184 * feat(system table) : Adding missing requirements from Code Review #25184 * Enable System Table by default. * fixing bad dependencies in pom (#26472) * feat(ai): Create an "AI Image" custom block #25670 * Created AI content node * Created ai-content-service * Created AI prompt content extension * Update ai-content.service.ts * Optimised and aligned extension code * Resolved comments on PR * Removed ai content node file * Update ai-content.service.ts * Remove import path for ai-content-node * Updated the ai-prompt form * align ai text prompt extension * Resovled comments on pull * Fix the aiTextPrompt form * Updated extension related code * Update ai-content-prompt.plugin.ts * Remove some extra code * Fixed outside click for aiContentPrompt extension * Created ai content node * Updated ai-content node * Remove unused code, resolve comments on PR * ai-content-prompt extension code optimisation * Update ai-content-prompt.plugin.ts * Integrated with AI api * insert ai node on response * textPrompt extension code optimsation * Update ai-content.service.ts * Resolve comments on pull req * handle close extension on outside click and content flip fix * Added focus field method and type for form * Change name of ai node creation command * Update the ai-content icon in the actions menu list * Update ai-content-prompt.component.scss * Resolved comments on pull * Added pening status and update the name of destroy var * Implement ai-content-actions extension * ai-prompt extension code optimisation * ai-text-prompt block optimisation * Update main.ts * feat: Created ai image prompt extension * Resolve comments on pull * Created loader node and handle loading image * Resolve comments on PR * Code optimisation for ai-content-actions extension * Fix css for p-listbox * Handle ai content actions to work in two diff context, code optimisation * Code optimisation * clean code from extra code --------- Co-authored-by: Nikola Trajkovic <82508651+nikolatrajkovic24@users.noreply.github.com> Co-authored-by: Nikola <nikola@physician.me> Co-authored-by: Will Ezell <will@dotcms.com> * #25901 Unable to reuse content inside the variants (#26450) * refresh the content palette when the languge change * make a couple of less state updates * clean up * fix(core): Edit Contentlet: Allow User Write Code #26045 * fix: SonarQube regex warning * warning: avoid use RegEx * warning: avoid use RegEx * fix(core): Edit Options not Showing on UrlContent Page #26314 * dev (edit page state controller): regenerate menuItems when navigating inside the iframe * fix (edit page state controller): test was broken * feat(edit-content): Render TextField and TextArea Field to the Form #26442 * dev (edit content lib): add text area, default value and inputmode/type support * dev (dot edit content field): add comments to new code * dev (dot edit content form): add comment * dev (dot edit content field): change steps from any to 0.1 in decimals * dev (dot edit content lib): create field wrappers for text area and text field * dev (dot edit content): add and clean test cases * dev (edit content mock): remove duplicated code * dev (edit content): address feedback * fix (edit-content-form): styles were off * fix (edit content text area): min height was too high * dev (edit content field): address feedback * dev (mocks): separate fields * dev (edit content field): enhance testing * dev (edit content): general clean up * dev (edit content form): delete todo * Revert "feat(ai): Create an "AI Image" custom block #25670" (#26483) This reverts commit 4b7b189. * feat(block-editor): AI Node and AI Actions extension (#26055) (#26455) * Created AI content node * Created ai-content-service * Created AI prompt content extension * Update ai-content.service.ts * Optimised and aligned extension code * Resolved comments on PR * Removed ai content node file * Update ai-content.service.ts * Remove import path for ai-content-node * Updated the ai-prompt form * align ai text prompt extension * Resovled comments on pull * Fix the aiTextPrompt form * Updated extension related code * Update ai-content-prompt.plugin.ts * Remove some extra code * Fixed outside click for aiContentPrompt extension * Created ai content node * Updated ai-content node * Remove unused code, resolve comments on PR * ai-content-prompt extension code optimisation * Update ai-content-prompt.plugin.ts * Integrated with AI api * insert ai node on response * textPrompt extension code optimsation * Update ai-content.service.ts * Resolve comments on pull req * handle close extension on outside click and content flip fix * Added focus field method and type for form * Change name of ai node creation command * Update the ai-content icon in the actions menu list * Update ai-content-prompt.component.scss * Resolved comments on pull * Added pening status and update the name of destroy var * Implement ai-content-actions extension * ai-prompt extension code optimisation * ai-text-prompt block optimisation * Update main.ts * Resolve comments on pull * Resolve comments on PR * Code optimisation for ai-content-actions extension * Fix css for p-listbox --------- Co-authored-by: Nikola Trajkovic <82508651+nikolatrajkovic24@users.noreply.github.com> Co-authored-by: Nikola <nikola@physician.me> Co-authored-by: Will Ezell <will@dotcms.com> * feat(block-editor): AI Image prompt Block (#26405) (#26485) * Created AI content node * Created ai-content-service * Created AI prompt content extension * Update ai-content.service.ts * Optimised and aligned extension code * Resolved comments on PR * Removed ai content node file * Update ai-content.service.ts * Remove import path for ai-content-node * Updated the ai-prompt form * align ai text prompt extension * Resovled comments on pull * Fix the aiTextPrompt form * Updated extension related code * Update ai-content-prompt.plugin.ts * Remove some extra code * Fixed outside click for aiContentPrompt extension * Created ai content node * Updated ai-content node * Remove unused code, resolve comments on PR * ai-content-prompt extension code optimisation * Update ai-content-prompt.plugin.ts * Integrated with AI api * insert ai node on response * textPrompt extension code optimsation * Update ai-content.service.ts * Resolve comments on pull req * handle close extension on outside click and content flip fix * Added focus field method and type for form * Change name of ai node creation command * Update the ai-content icon in the actions menu list * Update ai-content-prompt.component.scss * Resolved comments on pull * Added pening status and update the name of destroy var * Implement ai-content-actions extension * ai-prompt extension code optimisation * ai-text-prompt block optimisation * Update main.ts * feat: Created ai image prompt extension * Resolve comments on pull * Created loader node and handle loading image * Resolve comments on PR * Code optimisation for ai-content-actions extension * Fix css for p-listbox * Handle ai content actions to work in two diff context, code optimisation * Code optimisation * clean code from extra code --------- Co-authored-by: Nikola Trajkovic <82508651+nikolatrajkovic24@users.noreply.github.com> Co-authored-by: Nikola <nikola@physician.me> Co-authored-by: Will Ezell <will@dotcms.com> * [Issue-25962] SEO improvements use a hand cursor for edit and preview buttons (#26473) * Merging with master * Merging with master * Merging with master * #25959 Adding image broken * Merging with master * #25959 Css fixes' * Merging with master * Merging with master * #25959 fix image not found * #25959 fix image not found * Adding meta tags service * PR feedback * Adding refactor * Adding refactor * Adding more tests for validate the test scenarios * Adding favicon validation * #25962 cursor pointer * Refactor service * Refactor service * Adding refactor service * Fixing tests * feat(ui): Login Screen Changes #26303 * dev (login component): change button to be primeng button * fix (login component): tests were broken * dev (login component): remove extra type from input * dev (dot login styles): change font size to small * dev (dot login component): make forgot password button a link and use native routing * fix(core): Unable to do push publish pages from the pages portlet #26451 * fix (pages store): we were not using the correct reference to get the item for PP action * dev (pages store): add test case * Issue 26476 unable to push experiments (#26478) * #24967 postman tests for deleting an Experiment * #26476 use proper method to solve content on variant * #26476 integration test * fix(experiment-reports): show the input name of the goal in the summary (#26482) * truncate decimal based on new rules (#26488) * fix(seo): UI disabled tab buttons in seo toolbar don't show properly (#26490) * Adding twitter fixes * #26193 Adding disabled for tab buttons * Adding PR feedback * Adding aria attr * Update dotmarketing-config.properties (#26492) * Fix #26349: Template Builder change auto save and publish to just auto save (#26494) * dev (dot template builder): change auto save and publish, to auto save * dev (dot template builder): remove comment * #26409 Calendar Design System implementation (#26469) * feat(p-calendar): implement DS of calendar * feat(p-calendar): fix sq comment * feat(p-calendar): fix comments * feat(p-calendar): fix comments * feat(p-calendar): fix comments * feedback requested (#26493) * feedback requested * #26380 fixing bug * #26380 remove commented attributes no longer used * #26380 changing classes to immutables * #26380 these attribute will be moved later * #26380 renaming the new classes * feat(edit-content): Edit Content: Render Radio and Select Field to the Form #26448 * Added Select and Radio fields. Added basic tests on both components. Changed formData structure and architecture * Added validation to set, in case dont have value or defaultValue, the first option as value in select and radio field * Added enum to DataType * Added tests. Changed mocks. * Working on PR Suggestions. Commit before merge * Added merge with master. Added Typing to forms on Select and Radio button. Added more test cases * Pair programming select tests * Changed tests. Changed language of mocks. Moved folders to shared/ * Replaced shared folder with models content * Changed and added test to RadioButton field * Changed name on util => function * Working on DotEditContentForm tests * Solved test on DotEditContentForm * Pair programming tests for dot-edit-content * Added more tests. Reduced html on radio field. Casting values on init form --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * #26193 Adding fix for tabs (#26499) * fix(seo): Adding a mask to close when clicking outside of the modal (#26513) * #26089 Adding a mask to close when clicking outside of the modal * Adding test for the new html element * fix(seo): preview button should always take user to default preview (#26517) * #26419 default view * Removing export * feat(core): Multi Metadata Provider/Chainable Metadata Provider #24307 * feat(chainable metadata provider) : #24307 Introducing the composite chainable storage provider * Fixing Integration Tests * Implementing SonarQube feedback and fixing Integration Tests * #24307 adding just a comment * Fixing name as it said "4040" instead of "404" * #24307 adding more test * Fixing compile error in test. * #24307 adding test for dotconnect * Implementing SonarQube feedback. --------- Co-authored-by: jdotcms <jonathan.sanchez@dotcms.com> * feat(edit-content): Edit Content add Calendar related fields #26512 * dev (dot edit content calendar field): create and adapt to the lib * dev (edit content): integrate component with the lib and cleanups * fix(edit-content): Add icons to calendar field * Issue 25967 include user activity log experiments (#26496) * #24967 postman tests for deleting an Experiment * #25967 Log user activity on operations on Experiments * #25967 proper action * Create label-issues.yml * chore(ui): Add storybook and styles for Autocomplete #26376 * fix (autocomplete styles): focus state * fix (autocomplete styles): add styles for clear icon * dev (autocomplete story): add controls for the autocomplete * fix: remove redundant close ref#26374 (#26381) * Making possible to edit content within the Edit Page, regardless of the portlets you have assigned. (#26447) * #22698 adding fix * #22698 adding test * #22698 improving code readability * #22698 gh feedback * #22698 improving code * #22698 refactoring code --------- Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com> * Making Workflow API capable to archive contentlet (#26479) * #22698 remove error cause * #22921 adding fix * #22921 adding postman test * #22921 mini rollback --------- Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com> * feat(edit-content) Add Checkbox and Multiselect Fields to the Form #26491 * Working on Checkbox * Working on Checkbox and MultiSelect * feat(edit-content): fix DotEditContentMultiSelectFieldComponent test * feat(edit-content): fix DotEditContentMultiSelectFieldComponent test * feat(edit-content): fix DotEditContentMultiSelectFieldComponent final test * Revert "feat(edit-content): fix DotEditContentMultiSelectFieldComponent test" This reverts commit 5ef6b3c. * Fix multiselect test * Clean up --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> Co-authored-by: Arcadio Quintero <oidacra@gmail.com> * feat(edit-content) Add Tags Field #26526 * dev (dot select item directive): create directive to add items to autocomplete on enter * dev (add styles classed dialog): add the directive on template builder autocomplete * fix (autocomplete styles): fix spacings of util icons * dev (edit content tag component): create component for tag * dev (edit content): add tag component to form * fix (edit content form): save contentlet was not working for tags * fix (edit content): fix after merge conflcits * dev (autocomplete styles): fix positioning of icons and buttons * dev (autocomplete styles): fix margin * clean up (functon utils): reduce cyclomatic complexity * clean up: (autocomplete styles) * feat(core): #24307 Introducing the Redis Storage Provider (#26540) * feat(core): #25184 Fixing code to make POST method both save and update a key/value pair (#26530) * feat(system table) #25184 : Fixing code to make POST method both save and update a key/value pair. * Updating the Postman test to include a new scenario. * Implementing SonarQube feedback * Reverting odd change in "_collection_link" attribute. * fix(core): Autocomplete dropdown button missplaced * chore(edit-content): Add missing tests for multiselect field * feat(core): Add new containers portlet and make old legacy (#26574) * fix(edit-content): Margin and Padding of Columns and Fields #26564 * Edit Contentlet: Allow File Preview (#26470) * dev: create file preview component * dev: filew preview v1 * dev: get data preview from binary field response * dev: show preview from tempAPI * dev: let user edit images * test: fix current test suit v1 * dev: tests & clean up * test * test: fix DotDropZoneComponent tests * dev: fix SonarQube Warnings * dev: fix binary field build * dev: fix storybook * styles: responsive design for preview * clean up * docs: document components methods * feedback v1 * feedback v2 * feedback: pupdate tests v3 * feedback: remove CoreWebService from DotLicenseService * clean up * feedback: fix typo * clean up * clean up styles * clean up * fix: add publish and unpublish date (#25233) * #25233 changed to add only new field publish_date * feat(content cleanup) : Automatically prune File Asset versions exceeding a configurable limit #26188 (#26350) * fix(content cleanup) : Automatically prune File Asset versions exceeding a configurable limit #26188 * Implementing SonarQube feedback. * Implementing SonarQube feedback. * Fixing test class name. * Issue #26425: Support Multi lang when include MultiTree Contentlet inside a Bundle (#26438) * feat(core): Multi Metadata Provider/Chainable Metadata Provider #24307 * feat(chainable metadata provider) : #24307 Introducing the composite chainable storage provider * Fixing Integration Tests * Implementing SonarQube feedback and fixing Integration Tests * #24307 adding just a comment * Fixing name as it said "4040" instead of "404" * #24307 adding more test * Fixing compile error in test. * #24307 adding test for dotconnect * Implementing SonarQube feedback. --------- Co-authored-by: jdotcms <jonathan.sanchez@dotcms.com> * #26271 [UI] Text in experiment data results needs be aligned (#26578) * reduce decimals in graphic labels * test * keep two decimlas * chore(test): Edit Content: Create Tests for Utils Functions #26559 * dev (function utils): add test cases and clean up * dev (function utils spec): enhance logging * dev (function utils): enhance test cases * dev (function utils): enhance test cases * fix (function utils test): make date test bulletproof * fix: add publish and unpublish date (#25233) * feat(content cleanup) : Automatically prune File Asset versions exceeding a configurable limit #26188 (#26350) * fix(content cleanup) : Automatically prune File Asset versions exceeding a configurable limit #26188 * Implementing SonarQube feedback. * Implementing SonarQube feedback. * Fixing test class name. * feat(core): Multi Metadata Provider/Chainable Metadata Provider #24307 * feat(chainable metadata provider) : #24307 Introducing the composite chainable storage provider * Fixing Integration Tests * Implementing SonarQube feedback and fixing Integration Tests * #24307 adding just a comment * Fixing name as it said "4040" instead of "404" * #24307 adding more test * Fixing compile error in test. * #24307 adding test for dotconnect * Implementing SonarQube feedback. --------- Co-authored-by: jdotcms <jonathan.sanchez@dotcms.com> * fix: add publish and unpublish date (#25233) * #25233 : revert changes in mssql schema * #25233: reindex content with new publish_date column values populated * #25233 removed calls to api to reindex content * #25233 Renamed upgrade task to use appropriate date --------- Co-authored-by: KevinDavilaDotCMS <144152756+KevinDavilaDotCMS@users.noreply.github.com> Co-authored-by: Freddy Rodriguez <freddy0309@gmail.com> Co-authored-by: Arcadio Quintero <oidacra@gmail.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Victor Alfaro <victor.alfaro@dotcms.com> Co-authored-by: Jose Castro <jose.castro@dotcms.com> Co-authored-by: Will Ezell <will@dotcms.com> Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> Co-authored-by: Daniel Enrique Colina Rodríguez <danielcolina@gmail.com> Co-authored-by: daniel.colina <daniel.colina@dotcms.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Fabrizzio Araya <37148755+fabrizzio-dotCMS@users.noreply.github.com> Co-authored-by: Daniel Silva <daniel.silva@dotcms.com> Co-authored-by: freddyDOTCMS <147462678+freddyDOTCMS@users.noreply.github.com> Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com> Co-authored-by: Nikola Trajkovic <82508651+nikolatrajkovic24@users.noreply.github.com> Co-authored-by: Nikola <nikola@physician.me> Co-authored-by: Humberto Morera <31667212+hmoreras@users.noreply.github.com> Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com> Co-authored-by: AndreyDotcms <127987858+AndreyDotcms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Screenshots
Before
Screen.Recording.2023-10-16.at.11.18.58.AM.mov
After
Screenshare.-.2023-10-17.2_05_13.PM.mp4