onItemDeselect does not return object

[simeg]

My options:
$scope.optionsMultiSelect = {
displayProp: 'value', idProp:'value', externalIdProp: '' };
externalIdProp is set to '' so it should return an object.

onItemSelect returns the object. onItemDeselect just returns value which is a string.

Have I misunderstood the documentation or is this a bug?

[DavidCasillasRivero]

When setting externalIdProp='' the event onItemDeselect is returning an object with just the id property, while the event onItemSelectreturns the whole item. Inspecting the code you can see the difference:

                if (!dontRemove && exists) {
                    $scope.selectedModel.splice(_.findIndex($scope.selectedModel, findObj), 1);
                    $scope.externalEvents.onItemDeselect(findObj);
                } else if (!exists && ($scope.settings.selectionLimit === 0 || $scope.selectedModel.length < $scope.settings.selectionLimit)) {
                    $scope.selectedModel.push(finalObj);
                    $scope.externalEvents.onItemSelect(finalObj);
                }

Here finalObj has an item with all properties (id, and labelplus any other) while findObj just has the id property. The event onItemSelectis being called with finalObjwhile onItemDeselect is called with findObj.

I have modified myself the line of code for testing and everything is going ok.

Is this a bug? Will it be fixed?

[dgwaldo]

Having the same issue here... This is a bit of a tough bug, because I have multiple drop-downs, and I can't figure out what my id's relate to as far as objects go...

[pkempenaers]

Setting externalIdProp to "" will return full items instead of only id.

[pybelecalo]

Hello pkempenaers,

This bug is not fixed. Like he says DavidCasillasRivero, we are mandated to change findObj to finalObj to resolve our problem.

This bug must to be fixed.