create rdg7 sample #200
Merged
create rdg7 sample #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
commented
Sep 29, 2023
| public record Todo(int Id, string Task); | ||
|
|
||
| [JsonSerializable(typeof(Todo[]))] | ||
| internal partial class AppJsonSerializerContext : JsonSerializerContext |
There was a problem hiding this comment.
I looked at the other RDG examples, but I think this isn't required here?
There was a problem hiding this comment.
It was needed in the first sample and I just copied it. Maybe I can get rid of it in all my samples.
|
@timdeschryver great work. Your changes will be live in 15 minutes. Can you take a look at the live version and open any need issues? |
|
@Rick-Anderson thank you. The changes are looking good, but I messed up a highlight. I will fix this in an upcoming PR. |
|
Easy to fix from the browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/AspNetCore.Docs#30479
Needs to be merged before dotnet/AspNetCore.Docs#30527