Skip to content

Conversation

martincostello
Copy link
Member

Use PackageIcon instead of PackageIconUrl to resolve NU5048 warning.

Should unblock #1897.

Validated using NuGetPackageExplorer on a local package created with dotnet pack.

image

Use PackageIcon instead of PackageIconUrl.
@adamsitnik adamsitnik requested a review from AndreyAkinshin May 16, 2022 15:24
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @martincostello !

@adamsitnik adamsitnik merged commit fcda33a into dotnet:master Jun 23, 2022
@martincostello martincostello deleted the Use-PackageIcon branch June 23, 2022 12:48
@AndreyAkinshin AndreyAkinshin added this to the v0.13.2 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants