Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored BaseHttpCommand and added couple of tests to verify format behavior #115

Merged
merged 11 commits into from
Jul 26, 2019
Merged

Refactored BaseHttpCommand and added couple of tests to verify format behavior #115

merged 11 commits into from
Jul 26, 2019

Conversation

bhsubra
Copy link
Contributor

@bhsubra bhsubra commented Jul 25, 2019

As a part of this pr:

  • Refactored BaseHttpCommand class to make it more readable
  • Added couple of tests to verify format behavior based on content type
  • I did not find more areas for testing as most of the areas are covered by Commands that implement the abstract methods. Let me know if you have any suggestions around adding more tests

@bhsubra bhsubra requested review from tlmii and jimmylewis July 25, 2019 15:56
@bhsubra bhsubra mentioned this pull request Jul 26, 2019
Open
@bhsubra bhsubra force-pushed the dev/bhsubra/RefactorBaseHttpCommand branch from 11d6646 to 67ad93c Compare July 26, 2019 22:11
@bhsubra bhsubra merged commit be20c00 into master Jul 26, 2019
@jimmylewis jimmylewis deleted the dev/bhsubra/RefactorBaseHttpCommand branch August 2, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmylewis jimmylewis jimmylewis approved these changes

@tlmii tlmii tlmii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhsubra @jimmylewis @tlmii