-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Analyzers #249
Merged
Merged
Adding Analyzers #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmylewis
reviewed
Sep 30, 2019
jimmylewis
reviewed
Sep 30, 2019
jimmylewis
reviewed
Sep 30, 2019
jimmylewis
reviewed
Sep 30, 2019
jimmylewis
reviewed
Sep 30, 2019
jimmylewis
reviewed
Sep 30, 2019
jodavis
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jimmylewis
reviewed
Oct 1, 2019
jimmylewis
reviewed
Oct 1, 2019
jimmylewis
reviewed
Oct 1, 2019
jimmylewis
reviewed
Oct 1, 2019
jimmylewis
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is all about enabling analyzers on HttpRepl and addressing the errors that came from it. I took the
.ruleset
files from https://github.com/aspnet/LibraryManager. This PR touched a good number of files, so I broke up the changes into four parts:For that last commit, the analzers wanted me to put things like
HTTP
,;
,,
,:
, and/
into resources. I realized it was because theSetColor
exension method's first parameter was namedtext
. Renaming that totextToColor
made the errors go away. I addressed all the ones that were actual localizable text first before doing that..