Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Analyzers #249

Merged
merged 10 commits into from
Oct 1, 2019
Merged

Adding Analyzers #249

merged 10 commits into from
Oct 1, 2019

Conversation

tlmii
Copy link
Member

@tlmii tlmii commented Sep 29, 2019

This PR is all about enabling analyzers on HttpRepl and addressing the errors that came from it. I took the .ruleset files from https://github.com/aspnet/LibraryManager. This PR touched a good number of files, so I broke up the changes into four parts:

  1. Commit 022d9da split the folder structure off so that test projects were in their own project separate from the main source.
  2. Commit f520782 enabled analyzers for the src/ projects
  3. Commit fe6b193 addressed all of the errors that were not related to strings/resources
  4. Commit 09d3d78 addressed the string/resources errors

For that last commit, the analzers wanted me to put things like HTTP, ;, ,, :, and / into resources. I realized it was because the SetColor exension method's first parameter was named text. Renaming that to textToColor made the errors go away. I addressed all the ones that were actual localizable text first before doing that..

Copy link
Contributor

@jodavis jodavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tlmii tlmii merged commit feb5c12 into dotnet:master Oct 1, 2019
@tlmii tlmii deleted the dev/add-analyzers branch October 1, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants