Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add void primitive #1035

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Add void primitive #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a389c8
Add Void to Resolve
HurricanKai Aug 13, 2022
83f4bb4
Add Test
HurricanKai Aug 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/generators/Silk.NET.SilkTouch.TypeResolution/PrimitiveTypeResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ public PrimitiveTypeResolver(TypeStore typeStore) : base(typeStore)
{
}

private static ExternalTypeReference CreateExternalTypeRef(string @namespace, string name)
=> new ExternalTypeReference(new IdentifierSymbol(@namespace), new IdentifierSymbol(name));
private static ExternalTypeReference CreateExternalTypeRef(string? @namespace, string name)
=> new ExternalTypeReference(@namespace is not null ? new IdentifierSymbol(@namespace) : null, new IdentifierSymbol(name));
private static readonly Dictionary<string, TypeReference> _typeMap = new Dictionary<string, TypeReference>()
{
["bool"] = CreateExternalTypeRef("System", "Boolean"),
Expand All @@ -35,6 +35,7 @@ private static ExternalTypeReference CreateExternalTypeRef(string @namespace, st
["ulong"] = CreateExternalTypeRef("System", "UInt64"),
["short"] = CreateExternalTypeRef("System", "Int16"),
["ushort"] = CreateExternalTypeRef("System", "UInt16"),
["void"] = CreateExternalTypeRef(null, "void")
};

/// <inheritdoc />
Expand Down
3 changes: 2 additions & 1 deletion tests/Silk.NET.SilkTouch.TypeResolution.Tests/PrimitiveTypeResolverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ public sealed class PrimitiveTypeResolverTests
InlineData("ulong", "System", "UInt64"),
InlineData("short", "System", "Int16"),
InlineData("ushort", "System", "UInt16"),
InlineData("void", null, "void"),
]
public void ShouldResolve(string text, string @namespace, string identifier)
public void ShouldResolve(string text, string? @namespace, string identifier)
{
var symbol = new UnresolvedTypeReference(text);
var output = new PrimitiveTypeResolver(new TypeStore());
Expand Down