Jusjohns readme batch update for gallery #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@conceptdev here's a weird edge case I'm not sure what to do about. My processor will add a single markdown screenshot if:
This file uses HTML to embed an image so my processor added an additional screenshot. Also, the screenshots are enormous: Thoughts? |
|
My vote is to leave your processor as-is, and edit some of the outlying READMEs directly to comply with our assumptions. If the list of required changes gets long, we can reach out to get some help from the PMs. |
conceptdev
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a batch update to prepend yaml headers and normalize readmes for ingestion into a new gallery system.