[Xamarin.Android.Build.Tasks] ignore aapt/AndroidManifest.xml #2144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://stackoverflow.com/questions/41592744/function-of-aapt-androidmanifest-xml-in-aar
Fixes: #2141
Apparently Android Studio is now shipping a duplicate, pre-formatted
AndroidManifest.xml
file, inside of AAR files. Its purpose is to beused with
aapt
invocations, since errors may be thrown related to{
or}
characters.Since this file may exist in AAR files used by Xamarin.Android, we
should ignore
aapt/AndroidManifest.xml
files the same way we ignorethem inside
manifest
orbin
directories.Changes:
IgnoredManifestDirectories
list, since we are getting to apoint where
!= && != && !=
would be a lot of noise.foreach
loop, which shouldalso give a slight performance benefit.