[Mono.Android] Backfill map.csv API levels. #4703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
that referenced
this pull request
May 26, 2020
In commit 91970b1 we updated `src/Mono.Android/map.csv` to a new version that contains entries for all Java `int` fields and the API level in which they were introduced. However this file was generated before commit 3f438e4, which greatly increased the accuracy of our API level contents Use the increased accuracy of 3f438e46to to fill in many lines which previously did not have API level information (ApiLevel = 0). This commit does not change anything shipped, it's just better bookkeeping for more accurate enumification.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4665 we updated our
Mono.Android.dllmap.csvto a new version that contains entries for all Java int fields and the API level they were introduced. However this file was generated before #4671 was created, which greatly increased the accuracy of our API levels.This PR uses the increased accuracy to fill in many lines which previously did not have API level information (ApiLevel = 0).
This PR does not change anything shipped, it's just better bookkeeping for more accurate enumification.