Fix rabbit mq bindings in manifest. #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
|
/cc @DamianEdwards I think we might need to revise our guidance in samples about referencing the db creation project directly, it is best for the db context to be in its own library. |
davidfowl
reviewed
Jan 30, 2024
davidfowl
reviewed
Jan 30, 2024
davidfowl
approved these changes
Jan 31, 2024
|
/backport to release/8.0-preview3 |
|
Started backporting to release/8.0-preview3: https://github.com/dotnet/aspire/actions/runs/7720241404 |
|
@mitchdenny backporting to release/8.0-preview3 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix rabbit mq bindings in manifest.
.git/rebase-apply/patch:142: trailing whitespace.
.git/rebase-apply/patch:165: trailing whitespace.
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M Aspire.sln
Falling back to patching base and 3-way merge...
Removing playground/eShopLite/infra/main.parameters.json
Removing playground/eShopLite/infra/main.bicep
Removing playground/eShopLite/infra/eshoplite/app.bicep
Removing playground/eShopLite/azure.yaml
Auto-merging Aspire.sln
CONFLICT (content): Merge conflict in Aspire.sln
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix rabbit mq bindings in manifest.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@mitchdenny an error occurred while backporting to release/8.0-preview3, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
mitchdenny
added a commit
that referenced
this pull request
Jan 31, 2024
* Fix rabbit mq bindings in manifest. * Use 3 tag for RMQ, and checkin manifest.
davidfowl
pushed a commit
that referenced
this pull request
Jan 31, 2024
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 2, 2024
* Fix rabbit mq bindings in manifest. * Use 3 tag for RMQ, and checkin manifest.
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
* Fix rabbit mq bindings in manifest. * Use 3 tag for RMQ, and checkin manifest.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1973
... and then some. I change
AppHostover to using Rabbit MQ container since we don't yet haverabbitmq.v0support in AZD. This allows us to deploy eshoplite via AZD. As part of that work I had to move the EF data context that was in CatalogDb app into a shared library so it could be shared by CatalogService. Having CatalogService referencing CatalogDb created some publish time issues and this was the easiest workaround.Whilst the app now deploys cleanly to AZD there are some issues associated with scaling. Specifically the rabbit mq container scales to zero. I am not 100% sure but I don't think you can scale up when you aren't using a HTTP binding in ACA.
Microsoft Reviewers: Open in CodeFlow