Update sln templates to special-case CLI instead of VS #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Apr 25, 2024
src/Aspire.ProjectTemplates/templates/aspire-empty/.template.config/template.json
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Apr 25, 2024
src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/template.json
Outdated
Show resolved
Hide resolved
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8837362240 |
|
Does anything need to be updated so this case gets verified by CTI? |
I assume they're already covering C# Dev Kit. |
smitpatel
approved these changes
Apr 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the solution templates so that instead of special-casing VS and not creating the .sln file, they special-case the CLI and only create the .sln file in that case. This matches what the Blazor templates do and makes the templates work correctly in non-VS hosts like C# Dev Kit.
Fixes #3951
Microsoft Reviewers: Open in CodeFlow