Testclient getasync not returning right statuscode.

[sabrigo]

When making a call to a non-existent url, the getasync should return 404 not found error, however it is always returning response status as ok, even though there is no catch all situation I have implemented.

Further, when enabled verbose logging (screenshot below), I get the following information but the response status was sent as 200.

		public async Task Get_Should_ThrowError_When_ARoute_Is_Invalid()
		{
			var hostBuilder =
				new HostBuilder().ConfigureWebHost(webHost =>
				{
					webHost.UseTestServer();
                                        webHost.UseStartup<Startup>();
				});
			var host = hostBuilder.StartAsync().Result;

			await Assert.ThrowsAsync<Exception>(async () =>
			{
				var client = host.GetTestClient();
				var response = await client.GetAsync($"RequestUri");
				var result = await response.Content.ReadAsStringAsync();
			});
		}

[Tratcher]

Please share the code for Startup in this example.

[Tratcher]

Also, what exception are you expecting here? GetAsync doesn't throw for 404 responses, it returns a response message with the 404 status set.

[sabrigo]

using AutoMapper;
using FluentValidation;
using FluentValidation.AspNetCore;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;
using Product.Api.Services;
using Product.Mapper;
using Product.Models;
using Product.Services;
using Serilog;
using Newtonsoft.Json;

namespace Product.Api
{
	public class Startup
	{

		public Startup(IConfiguration configuration)
		{
			Configuration = configuration;
		}

		public IConfiguration Configuration { get; }

		// This method gets called by the runtime. Use this method to add services to the container.
		public void ConfigureServices(IServiceCollection services)
		{
			services.AddRouting();
			services.AddControllers();
			services.AddMvcCore(options => options.EnableEndpointRouting = false);
			services.AddAutoMapper(cfg =>
			{
				cfg.Advanced.MaxExecutionPlanDepth = 1;
			}, typeof(ProductMapperProfile).Assembly);
			services.AddMvcCore().AddFluentValidation().AddNewtonsoftJson(options=>
			{
				options.SerializerSettings.ReferenceLoopHandling = ReferenceLoopHandling.Ignore;
				options.SerializerSettings.PreserveReferencesHandling = PreserveReferencesHandling.None;
				options.SerializerSettings.MaxDepth = 1;
			});
			RegisterProductServices(services);
		}

		private void RegisterProductServices(IServiceCollection services)
		{
			var connectionString = Configuration.GetConnectionString("ProductDb");
			ProductServices.Register(services, connectionString);
			services.AddTransient<IValidator<ProductViewModel>, ProductViewModelValidator>();
			services.AddTransient<IValidator<ProductOptionViewModel>, ProductOptionViewModelValidator>();
			services.AddTransient<IProductApiServices, ProductApiServices>();
			services.AddTransient<IProductOptionApiService, ProductOptionApiService>();
		}

		// This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
		public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
		{
			if (env.IsDevelopment())
			{
				app.UseDeveloperExceptionPage();
			}

//			app.UseSerilogRequestLogging();

			app.UseHttpsRedirection();

			app.UseRouting();

			app.UseMvc();

			app.UseAuthorization();

			app.Run(context => Task.CompletedTask );
		}
	}
}

[sabrigo]

As you can see from the earlier screen shot, that the response does return even the status set 404, if so where/how do I find it

[Tratcher]

Remove    app.Run(context => Task.CompletedTask);
This causes every request to be considered handled with the default 200 status rather than reach the default end of the pipeline that changes the status to 404.

[analogrelay]

Closing this as we believe the question has been answered. Let us know if you have further questions!