Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies from the default set adding by ConfigureWebHost #5944

Closed
davidfowl opened this issue Nov 12, 2018 · 8 comments
Closed

Remove dependencies from the default set adding by ConfigureWebHost #5944

davidfowl opened this issue Nov 12, 2018 · 8 comments
Assignees
Labels
area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions breaking-change This issue / pr will introduce a breaking change, when resolved / merged.

Comments

@davidfowl
Copy link
Member

Today we add a set of dependencies that mirror the WebHostBuilder https://github.com/aspnet/Hosting/blob/d7b9fd480765bdc01f06441f308fb288e6001049/src/Microsoft.AspNetCore.Hosting/WebHostBuilder.cs#L270-L285. Things we may want to remove:

  • ObjectPoolProvider
  • DiagnosticListener/DiagnosticSource

@Tratcher @rynowak

@Tratcher
Copy link
Member

Are you tracking the removal of server.Urls and other obsolete config settings somewhere?

@davidfowl
Copy link
Member Author

I removed the server.urls in the PR.

@sandersaares
Copy link
Contributor

more pay for play

What does this phrase in the announcement mean?

@davidfowl
Copy link
Member Author

@sandersaares Components that require the ObjectPoolProvider add it instead of it being added for everyone (it was only used in 3 places). Where as something like logging is user by every component.

@BonnieSoftware
Copy link
Contributor

I'm not a big fan of dependencies being added by default, and I suspect there are going to be more cases where dependencies are added like so, is there going to be a wider review to see if we can make improvements elsewhere as part of this breaking change?

@davidfowl davidfowl self-assigned this Jan 23, 2019
@davidfowl
Copy link
Member Author

I'm not a big fan of dependencies being added by default, and I suspect there are going to be more cases where dependencies are added like so, is there going to be a wider review to see if we can make improvements elsewhere as part of this breaking change?

Yes the dependencies listed are the ones that are problematic/unnecessary. The other dependencies are pretty much required to function.

@davidfowl davidfowl modified the milestones: 3.0.0, 3.0.0-preview3 Jan 23, 2019
@davidfowl
Copy link
Member Author

I'm not sure we can easily remove the diagnostic source. I need to think about that one more.

@davidfowl
Copy link
Member Author

Closing this as we're not going to remove (at least in the short term, the DiagnosticSource)

@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 3, 2019
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions breaking-change This issue / pr will introduce a breaking change, when resolved / merged.
Projects
None yet
Development

No branches or pull requests

8 participants