Skip to content

Revert "Add an option to SignalR to guarantee ordering of send events… #10807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2019
Merged

Revert "Add an option to SignalR to guarantee ordering of send events… #10807

merged 1 commit into from
Jun 3, 2019

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Jun 3, 2019

… (#10506)"

This reverts commit 4646c4a.

@BrennanConroy
Copy link
Member

Well... we can keep the change in SignalR and just remove all the infrastructure stuff.

@pranavkm
Copy link
Contributor Author

pranavkm commented Jun 3, 2019

Just keeping this prepped. I'd like to take a stab at fixing the build if I can with the change.

@Eilon Eilon added the area-signalr Includes: SignalR clients and servers label Jun 3, 2019
@BrennanConroy
Copy link
Member

Just keeping this prepped. I'd like to take a stab at fixing the build if I can with the change.

Sure, but a better prep is to not remove the feature you made :D

@pranavkm
Copy link
Contributor Author

pranavkm commented Jun 3, 2019

@aspnet/build could you merge this in? The official build is currently broken due to this change.

cc @Pilchie \ @mkArtakMSFT

natemcmaster
natemcmaster approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: We haven't had a successful build since the original PR went in, and it's blocking preview6 dependency flow. Let's avoid rushing in a fix and target preview7.

@natemcmaster natemcmaster merged commit 39a9d63 into release/3.0-preview6 Jun 3, 2019
@natemcmaster natemcmaster deleted the prkrishn/ordering2 branch June 3, 2019 22:50
pranavkm added a commit that referenced this pull request Jun 4, 2019
@pranavkm
Revert "Revert "Add an option to SignalR to guarantee ordering of sen…
d364955 
…d events… (#10807)"

This reverts commit 39a9d63.
dougbu pushed a commit that referenced this pull request Jun 5, 2019
@pranavkm @dougbu
Guarantee ordering for SignalR client HttpConnection.send (#10780)
b1a2928 
* Revert "Revert "Add an option to SignalR to guarantee ordering of send events… (#10807)"
  - This reverts commit 39a9d63.
* Fixup build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@analogrelay analogrelay Awaiting requested review from analogrelay

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@halter73 halter73 Awaiting requested review from halter73

@mikaelm12 mikaelm12 Awaiting requested review from mikaelm12

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

1 more reviewer

@natemcmaster natemcmaster natemcmaster approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavkm @BrennanConroy @natemcmaster @Eilon