Clear internal stream map on connection close. #12212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelm12
requested review from
analogrelay,
BrennanConroy and
halter73
as code owners
|
Needs to be updated based on conversation in #12135, going to make a draft for now |
jkotalik
approved these changes
Jul 16, 2019
halter73
reviewed
Jul 17, 2019
| assertTrue(hubConnection.getStreamMap().keySet().contains("2")); | ||
|
|
||
| // Verify that we clear the entry from the stream map after we clear the first stream. | ||
| stream.onComplete(); |
There was a problem hiding this comment.
Do we verify the streamMap entry gets removed when sendHubMessage completes with an error?
There was a problem hiding this comment.
Was just thinking this as I was headed to the restroom. I'll complete the second stream with an error and verify.
halter73
approved these changes
Jul 17, 2019
BrennanConroy
approved these changes
Jul 17, 2019
| @@ -109,6 +109,11 @@ void setTickRate(long tickRateInMilliseconds) { | |||
| this.tickRate = tickRateInMilliseconds; | |||
| } | |||
|
|
|||
| // For testing purposes | |||
| Map<String,Observable> getStreamMap() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12135
Clears our internal stream map on close.