Parsing extension-av on Set Cookie header #22181
Conversation
ghost
added
the
| @@ -554,12 +580,13 @@ public override bool Equals(object obj) | |||
| && StringSegment.Equals(Path, other.Path, StringComparison.OrdinalIgnoreCase) | |||
| && Secure == other.Secure | |||
| && SameSite == other.SameSite | |||
| && HttpOnly == other.HttpOnly; | |||
| && HttpOnly == other.HttpOnly | |||
| && HeaderUtilities.AreEqualCollections(Extensions, other.Extensions); | |||
There was a problem hiding this comment.
Does this consider order of extensions?
There was a problem hiding this comment.
Changed that to consider order of extensions
There was a problem hiding this comment.
Sorry, I meant the opposite, order shouldn't matter.
There was a problem hiding this comment.
Oh, I was thinking what you meant by that and chose the wrong option. I have reverted it back and changed the test for it.
There was a problem hiding this comment.
Yeah, I just meant to ask about the behavior of HeaderUtilities.AreEqualCollections.
There was a problem hiding this comment.
Just to confirm things. The HeaderUtilities.AreEqualCollections is indeed checking if two unordered list have same content. It does it in O(n*m) time, but since the number of extensions is not likely to reach any high number, so it doesn't really matter.
Because extension-av doesn't have any fixed format we have to look after commas when parsing to determine end of Set-Cookie string
ostorc
changed the title
BrennanConroy
added
the
api-suggestion
|
@ostorc Can you take a look at the feedback? |
|
@ostorc Are you still working on this? |
|
Hi, I am sorry for the dealy. I had really busy week. I will finish changes today and update the PR. |
|
Conflict resolved |
|
Thanks |
amcasey
added
area-networking
This PR adds support for parsing extension-uv and storing data retrieved from it.
Fixes #22077