Add nullable annotations to Healthchecks #22785
Conversation
Pilchie
added
the
area-healthchecks
BrennanConroy
added
the
api-ready-for-review
|
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
| @@ -8,6 +8,6 @@ public sealed class HealthCheckContext | |||
| /// <summary> | |||
| /// Gets or sets the <see cref="HealthCheckRegistration"/> of the currently executing <see cref="IHealthCheck"/>. | |||
| /// </summary> | |||
| public HealthCheckRegistration Registration { get; set; } | |||
| public HealthCheckRegistration Registration { get; set; } = default!; | |||
There was a problem hiding this comment.
Was this only nullable for testing? Should add comment why it has been forced to non-nullable
There was a problem hiding this comment.
Yeah, the calling code assumes this is non-null.
| @@ -243,7 +243,7 @@ public async Task CheckHealthAsync_SetsRegistrationForEachCheck() | |||
| public async Task CheckHealthAsync_Cancellation_CanPropagate() | |||
| { | |||
| // Arrange | |||
| var insideCheck = new TaskCompletionSource<object>(); | |||
| var insideCheck = new TaskCompletionSource<object?>(); | |||
There was a problem hiding this comment.
Non generic TaskCompletionSource is merged in runtime. We should have it soon 🙏
|
Hello @pranavkm! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
|
@BrennanConroy the suggestion was to review these together rather than individually. I'll set up a separate review once we've had more of these projects updated. |
pranavkm
removed
the
api-ready-for-review
No description provided.