Skip to content

Fix Windows 7 Kestrel tests #23069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 19, 2020
Merged

Fix Windows 7 Kestrel tests #23069

merged 5 commits into from
Jun 19, 2020

Conversation

JunTaoLuo
Copy link
Contributor

Not sure how these tests were missed in the previous iteration #22918.

JunTaoLuo
JunTaoLuo commented Jun 18, 2020
View reviewed changes
.azure/pipelines/ci.yml Outdated
@@ -608,7 +608,7 @@ stages:
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -restore -noBuild -noBuildNative -projects src/Grpc/**/*.csproj
displayName: Restore interop projects
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -noRestore -test -all -noBuildNative -projects eng\helix\helix.proj
/p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true
/p:IsHelixDaily=true /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert before merging.

@JunTaoLuo
Copy link
Contributor Author

I'm seeing some errors on Win7

[xUnit.net 00:00:06.10]     ClientHandshakeFailureLoggedAsDebug [FAIL]
[xUnit.net 00:00:06.10]       Log Error[0]: Unhandled exception while processing 0HM0J4M7ACO74. System.AggregateException: An error occurred while writing to logger(s). (An attempt was made to transition a task to a final state when it had already completed.)
[xUnit.net 00:00:06.10]        ---> System.InvalidOperationException: An attempt was made to transition a task to a final state when it had already completed.
[xUnit.net 00:00:06.10]          at System.Threading.Tasks.TaskCompletionSource.SetResult()
[xUnit.net 00:00:06.10]          at Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests.HttpsTests.HttpsConnectionFilterLogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter) in /_/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsTests.cs:line 497
[xUnit.net 00:00:06.10]          at Microsoft.Extensions.Logging.Logger.<Log>g__LoggerLog|12_0[TState](LogLevel logLevel, EventId eventId, ILogger logger, Exception exception, Func`3 formatter, List`1& exceptions, TState& state)
[xUnit.net 00:00:06.10]          --- End of inner exception stack trace ---
[xUnit.net 00:00:06.10]          at Microsoft.Extensions.Logging.Logger.ThrowLoggingError(List`1 exceptions)
[xUnit.net 00:00:06.10]          at Microsoft.Extensions.Logging.Logger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
[xUnit.net 00:00:06.10]          at Microsoft.Extensions.Logging.Logger`1.Microsoft.Extensions.Logging.ILogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
[xUnit.net 00:00:06.10]          at Microsoft.Extensions.Logging.LoggerMessage.<>c__DisplayClass4_0.<Define>b__0(ILogger logger, Exception exception)
[xUnit.net 00:00:06.10]          at Microsoft.AspNetCore.Server.Kestrel.Https.Internal.HttpsConnectionMiddlewareLoggerExtensions.AuthenticationFailed(ILogger logger, Exception exception) in /_/src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs:line 352
[xUnit.net 00:00:06.10]          at Microsoft.AspNetCore.Server.Kestrel.Https.Internal.HttpsConnectionMiddleware.OnConnectionAsync(ConnectionContext context) in /_/src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs:line 232
[xUnit.net 00:00:06.10]          at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.KestrelConnection`1.ExecuteAsync() in /_/src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelConnectionOfT.cs:line 52
[xUnit.net 00:00:06.10]       Expected: True
[xUnit.net 00:00:06.10]       Actual:   False
[xUnit.net 00:00:06.10]       Stack Trace:
[xUnit.net 00:00:06.10]         /_/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsTests.cs(169,0): at Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests.HttpsTests.ClientHandshakeFailureLoggedAsDebug()
[xUnit.net 00:00:06.10]         --- End of stack trace from previous location ---
[xUnit.net 00:00:16.98]     EmptyRequestLoggedAsDebug [FAIL]
[xUnit.net 00:00:16.98]       Log Error[0]: Unhandled exception while processing 0HM0J4M7ACOMM. System.AggregateException: An error occurred while writing to logger(s). (An attempt was made to transition a task to a final state when it had already completed.)
[xUnit.net 00:00:16.98]        ---> System.InvalidOperationException: An attempt was made to transition a task to a final state when it had already completed.
[xUnit.net 00:00:16.98]          at System.Threading.Tasks.TaskCompletionSource.SetResult()
[xUnit.net 00:00:16.98]          at Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests.HttpsTests.HttpsConnectionFilterLogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter) in /_/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsTests.cs:line 497
[xUnit.net 00:00:16.98]          at Microsoft.Extensions.Logging.Logger.<Log>g__LoggerLog|12_0[TState](LogLevel logLevel, EventId eventId, ILogger logger, Exception exception, Func`3 formatter, List`1& exceptions, TState& state)
[xUnit.net 00:00:16.98]          --- End of inner exception stack trace ---
[xUnit.net 00:00:16.98]          at Microsoft.Extensions.Logging.Logger.ThrowLoggingError(List`1 exceptions)
[xUnit.net 00:00:16.98]          at Microsoft.Extensions.Logging.Logger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
[xUnit.net 00:00:16.98]          at Microsoft.Extensions.Logging.Logger`1.Microsoft.Extensions.Logging.ILogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
[xUnit.net 00:00:16.98]          at Microsoft.Extensions.Logging.LoggerMessage.<>c__DisplayClass4_0.<Define>b__0(ILogger logger, Exception exception)
[xUnit.net 00:00:16.98]          at Microsoft.AspNetCore.Server.Kestrel.Https.Internal.HttpsConnectionMiddlewareLoggerExtensions.AuthenticationFailed(ILogger logger, Exception exception) in /_/src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs:line 352
[xUnit.net 00:00:16.98]          at Microsoft.AspNetCore.Server.Kestrel.Https.Internal.HttpsConnectionMiddleware.OnConnectionAsync(ConnectionContext context) in /_/src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs:line 232
[xUnit.net 00:00:16.98]          at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.KestrelConnection`1.ExecuteAsync() in /_/src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelConnectionOfT.cs:line 52
[xUnit.net 00:00:16.98]       Expected: True
[xUnit.net 00:00:16.98]       Actual:   False
[xUnit.net 00:00:16.98]       Stack Trace:
[xUnit.net 00:00:16.98]         /_/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsTests.cs(141,0): at Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests.HttpsTests.EmptyRequestLoggedAsDebug()
[xUnit.net 00:00:16.98]         --- End of stack trace from previous location ---
[xUnit.net 00:00:16.98]   Finished:    InMemory.FunctionalTests

It also seems like my changes in #22859 broke quite a few tests on Windows 8. Not sure why those weren't caught when I ran the tests in that PR. I'll fix those up.

@JunTaoLuo JunTaoLuo mentioned this pull request Jun 18, 2020
Closed
@JunTaoLuo JunTaoLuo merged commit bb92c60 into master Jun 19, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/more-helix-matrix branch June 19, 2020 07:24
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JunTaoLuo @halter73 @Pilchie @amcasey