Enable /warnAsError
#23072
Merged
Enable /warnAsError
#23072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dougbu
commented
Jun 18, 2020
dougbu
commented
- Allow some warnings related to closed issues
dougbu
commented
Jun 18, 2020
|
/fyi will run an internal pipeline once we drive warnings down enough for PR validation to succeed. We have a small amount of site extensions code that doesn't build in PR validation. |
|
As expected, #22992 blocks this. Warnings mentioned there are visible in all test builds. |
dougbu
commented
Jun 18, 2020
|
|
||
| # Disable node reuse - Workaround perpetual issues in node reuse and custom task assemblies | ||
| $nodeReuse = $false | ||
| $env:MSBUILDDISABLENODEREUSE=1 | ||
|
|
||
| # Our build often has warnings that we can't fix, like "MSB3026: Could not copy" due to race | ||
| # conditions in building C++ | ||
| # Fixing this is tracked by https://github.com/dotnet/aspnetcore-internal/issues/601 |
There was a problem hiding this comment.
Reminder to self: Close dotnet/aspnetcore-internal#601 when this PR goes in 😺
Pilchie
added
the
area-infrastructure
- already enabled in non-Windows builds because override existed only in build.ps1
- common `<NoWarn>$(NoWarn);CS1591</NoWarn>` case unchanged
- /Directory.Build.props ensures that warning remains a warning but doesn't hide it
- variable eng/common/tools.sh uses named `warn_as_error`
dougbu
force-pushed
the
dougbu/warn.as.error
branch
from
7abb247 to
2738e1e
Compare
Pilchie
approved these changes
Jun 18, 2020
|
Internal build https://dev.azure.com/dnceng/internal/_build/results?buildId=694625 built all product code, including site extensions. That build did not compile any test code but PR validation build https://dev.azure.com/dnceng/public/_build/results?buildId=694621 covered that. Both hit only the expected (for now) 8 or 9 per-build non- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.