Skip to content

Include identical helix script files directly #23116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2020
Merged

Include identical helix script files directly #23116

merged 2 commits into from
Jun 19, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jun 18, 2020 •
edited
Loading

Fixes #23021

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 18, 2020
@HaoK HaoK requested a review from a team June 18, 2020 21:52
dougbu
dougbu approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One down 😺 Do we need to parameterize some of the eng\scripts\Install*.* files to get more of this goodness❔

@HaoK
Copy link
Member Author

HaoK commented Jun 19, 2020

There really isn't much overlap, installnode.ps1 is the only other one really, although install chrome likely will be the next candidate once selenium tests light up

@HaoK HaoK merged commit 0dc6aa6 into master Jun 19, 2020
@HaoK HaoK deleted the haok/copy branch June 19, 2020 02:00
@dougbu dougbu mentioned this pull request Jun 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try to dedupe helix content scripts with eng/scripts
2 participants
@HaoK @dougbu