Made the encodings of .razor and .cshtml files in the repo consistent #23502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
requested review from
pranavkm and
mkArtakMSFT
and removed request for
Tratcher
ajaybhargavb
commented
Jun 30, 2020
| @@ -21,79 +21,78 @@ public ByteOrderMarkTest(ITestOutputHelper output) | |||
| _output = output; | |||
| } | |||
|
|
|||
| [ConditionalTheory] | |||
| [QuarantinedTest] | |||
| [Theory] | |||
There was a problem hiding this comment.
This is the actual code change here.
ajaybhargavb
commented
Jun 30, 2020
| <Content Include="..\Web.Spa.ProjectTemplates\**" LinkBase="Assets\Web.Spa.ProjectTemplates" /> | ||
| <Content Include="..\Web.ItemTemplates\**" LinkBase="Assets\Web.ItemTemplates" /> | ||
| <Content Include="..\Web.Client.ItemTemplates\**" LinkBase="Assets\Web.Client.ItemTemplates" /> | ||
| </ItemGroup> |
ajaybhargavb
changed the title
ajaybhargavb
added
area-blazor
ajaybhargavb
force-pushed
the
ajbaaska/fix-encodings
branch
from
be86316 to
a4aa668
Compare
sharwell
previously requested changes
Jun 30, 2020
There was a problem hiding this comment.
The .editorconfig needs to be updated as well, because it is currently configured to overwrite each of these changes the next time the file gets saved.
https://github.com/dotnet/aspnetcore/blob/be86316fcffdbf38039d2da7e512494aa17514a6/.editorconfig#L18
pranavkm
approved these changes
Jun 30, 2020
| <Content Include="..\Web.Spa.ProjectTemplates\**" LinkBase="Assets\Web.Spa.ProjectTemplates" /> | ||
| <Content Include="..\Web.ItemTemplates\**" LinkBase="Assets\Web.ItemTemplates" /> | ||
| <Content Include="..\Web.Client.ItemTemplates\**" LinkBase="Assets\Web.Client.ItemTemplates" /> | ||
| </ItemGroup> |
mkArtakMSFT
approved these changes
Jun 30, 2020
|
@mkArtakMSFT this is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22753