Skip gRPC template test on Windows 8.1 #23828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
|
FYI, this test shouldn't run since we require HTTP/2 over TLS for the gRPC template which is not available on 8.1 due to incompatible ciphers. |
|
Hello @JunTaoLuo! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Pilchie
approved these changes
Jul 9, 2020
ghost
merged commit 
dougbu
reviewed
Jul 10, 2020
| @@ -26,7 +26,7 @@ public GrpcTemplateTest(ProjectFactoryFixture projectFactory, ITestOutputHelper | |||
| public ITestOutputHelper Output { get; } | |||
|
|
|||
| [ConditionalFact] | |||
| [SkipOnHelix("Not supported queues", Queues = "Windows.7.Amd64;Windows.7.Amd64.Open;OSX.1014.Amd64;OSX.1014.Amd64.Open")] | |||
| [SkipOnHelix("Not supported queues", Queues = "Windows.7.Amd64;Windows.7.Amd64.Open;Windows.81.Amd64.Open;OSX.1014.Amd64;OSX.1014.Amd64.Open")] | |||
There was a problem hiding this comment.
Looks like we need a [OnlyRunOnHelix(...)] attribute to shorten the list😈
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Windows 8.1 failure in https://dev.azure.com/dnceng/public/_build/results?buildId=722486&view=ms.vss-test-web.build-test-results-tab