Use ordinal comparison when detecting event handler attributes. Fixes #24465 #24471
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
approved these changes
Jul 31, 2020
SteveSandersonMS
deleted the
stevesa/perf-ordinal-event-handler-detection
branch
HaoK
pushed a commit
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in #24465
It's actually giving a 4% gain on the PlainTable benchmark now, perhaps because there are fewer other instructions overall.
To avoid any confusion, this shouldn't break anyone's scenarios. The
ondetection was never meant to be culture-sensitive, and there's no scenario I know of where you would have an attribute name that matcheson...only due to culture sensitivity.