Skip to content

Remove unused HTML files #24488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2020
Merged

Remove unused HTML files #24488

merged 1 commit into from
Aug 2, 2020

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Jul 31, 2020

  • just a bit confusing to leave these around
  • the files haven't been used since @pakrym removed the resources in 56c064b

@dougbu
Remove unused HTML files
47f1fca 
- just a bit confusing to leave these around
- the files haven't been used since @pakrym removed the resources in 56c064b
@dougbu dougbu requested a review from a team July 31, 2020 20:18
@dougbu dougbu requested a review from Tratcher as a code owner July 31, 2020 20:18
@ghost ghost added the area-hosting label Jul 31, 2020
@dougbu
Copy link
Contributor Author

dougbu commented Jul 31, 2020

/fyi @davidfowl

@dougbu
Copy link
Contributor Author

dougbu commented Jul 31, 2020

/ping @JunTaoLuo checks are done and everything went well

@davidfowl
Copy link
Member

@dougbu before merge @Tratcher should do a look over. We have a built in error page in hosting as well as the middleware and these were used for that. If nothing is embedded I'm not sure where they are coming from.

@davidfowl
Copy link
Member

Yah the actual code is here now https://github.com/dotnet/aspnetcore/tree/master/src/Shared/ErrorPage

@dougbu
Copy link
Contributor Author

dougbu commented Aug 2, 2020

Yah the actual code is here now https://github.com/dotnet/aspnetcore/tree/master/src/Shared/ErrorPage

No need to wait for @Tratcher then❔

@davidfowl
Copy link
Member

Yea, merge it

@dougbu dougbu merged commit b534f92 into master Aug 2, 2020
@dougbu dougbu deleted the dougbu/remove.unused branch August 2, 2020 18:46
@JunTaoLuo
Copy link
Contributor

Post-hoc :shipit:

HaoK pushed a commit that referenced this pull request Aug 7, 2020
@dougbu @HaoK
Remove unused HTML files (#24488)
06075c4 
- just a bit confusing to leave these around
- the files haven't been used since @pakrym removed the resources in 56c064b
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidfowl davidfowl davidfowl approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

No one assigned

Labels

area-hosting Includes Hosting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dougbu @davidfowl @JunTaoLuo @amcasey