Skip to content

[Blazor][Identity] Update to the latest identity server version #25002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 19, 2020
Merged

[Blazor][Identity] Update to the latest identity server version #25002

merged 16 commits into from
Aug 19, 2020

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Aug 18, 2020 •
edited
Loading

  • Updates to IdentityServer 4.0.4
  • Updates templates with the new migrations.
  • Fixes a small configuration bug that required the configuration for the key to be specified.
  • Updates the Error url in IdentityServer config to match our template defaults.

@Pilchie Pilchie added the area-identity Includes: Identity and providers label Aug 18, 2020
@javiercn javiercn marked this pull request as ready for review August 18, 2020 20:21
@javiercn javiercn requested review from dougbu, SteveSandersonMS and a team as code owners August 18, 2020 20:21
javiercn
javiercn commented Aug 18, 2020
View reviewed changes
eng/Version.Details.xml
<Dependency Name="Microsoft.EntityFrameworkCore.Design" Version="5.0.0-rc.1.20417.2">
<Uri>https://github.com/dotnet/efcore</Uri>
<Sha>5099d918192f5df031e1ff5e3beea9cb361c605a</Sha>
</Dependency>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to run migrations on the projects within the repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit surprised it's not brought in transitively❔

javiercn
javiercn commented Aug 18, 2020
View reviewed changes
src/Identity/ApiAuthorization.IdentityServer/src/Configuration/ConfigureSigningCredentials.cs
// Check if the current configuration has any children and avoid failing if that's the case.
// This will avoid failing when no configuration has been specified but will still fail if partial data
// was defined.
if (!_configuration.GetChildren().Any())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a small bug that prevented the key to be just set in code (it would fail if config was not specified). I'll find the related issue and link it to this PR

@javiercn
Copy link
Member Author

I've validated the changes with the SPA templates too, even though it has been hell-ish.

I'll bring back the spa template tests to use for local validation in a separate PR for use with local development (No CI)

@javiercn javiercn merged commit 38563dd into release/5.0 Aug 19, 2020
@javiercn javiercn deleted the javiercn/identity-server-updates branch August 19, 2020 09:12
@javiercn javiercn added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 19, 2020
@denmitchell denmitchell mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu Awaiting requested review from dougbu

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS SteveSandersonMS is a code owner

1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-identity Includes: Identity and providers tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javiercn @pranavkm @dougbu @Pilchie