Added PageRequestDelegateFactory #28134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented the PageRequestDelegateFactory for razor pages - Refactored the PageActionInvokerProvider into a PageActionInvokerCache to mimic the controller implementation and to share logic. - Moved the cache to be part of the CompiledPageActionDescriptor itself. This simplifies the looked and expiration as it is tied to the CompiledPageActionDescriptor instance. - Skip the page loader for already compiled pages
ghost
added
the
area-mvc
pranavkm
reviewed
Nov 25, 2020
src/Mvc/Mvc.RazorPages/src/Infrastructure/PageRequestDelegateFactory.cs
Outdated
Show resolved
Hide resolved
davidfowl
commented
Nov 25, 2020
davidfowl
commented
Nov 25, 2020
Co-authored-by: Pranav K <prkrishn@hotmail.com>
pranavkm
approved these changes
Nov 25, 2020
|
Hello @davidfowl! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mimic the controller implementation and to share logic.
This simplifies the looked and expiration as it is tied to the
CompiledPageActionDescriptor instance.