Skip to content

Use generics trick to cache tag helper instances #28208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2020
Merged

Use generics trick to cache tag helper instances #28208

merged 1 commit into from
Nov 27, 2020

Conversation

davidfowl
Copy link
Member

  • Remove the use of ITypeActivatorCache

ITypeActivatorCache should really be used when types are truly dynamic (like when we scan for controllers)

@davidfowl
Use generics trick to cache tag helper instances
43977b7 
- Remove the use of ITypeActivatorCache
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Nov 27, 2020
@davidfowl davidfowl merged commit 27610b0 into master Nov 27, 2020
@davidfowl davidfowl deleted the davidfowl/cache-tag-helper branch November 27, 2020 19:44
@davidfowl davidfowl added this to the 6.0-preview1 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@pranavkm pranavkm Awaiting requested review from pranavkm

@javiercn javiercn Awaiting requested review from javiercn

@ajaybhargavb ajaybhargavb Awaiting requested review from ajaybhargavb

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
6.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfowl @JamesNK