Skip to content

Remove obsolete StaticFileResponseContext constructor #28893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2020
Merged

Remove obsolete StaticFileResponseContext constructor #28893

merged 1 commit into from
Dec 30, 2020

Conversation

Tratcher
Copy link
Member

#27529

Obsolete APIs in Middleware:

  • StaticFileResponseContext.ctor(): Obsolete since 3.0, and wasn't usable before that because all of the properties had internal setters. Replaced by a new constructor with parameters. Removed.

@Tratcher Tratcher self-assigned this Dec 28, 2020
@ghost ghost added the area-middleware label Dec 28, 2020
@Tratcher Tratcher added this to the 6.0-preview1 milestone Dec 30, 2020
@Tratcher Tratcher merged commit 43f9b67 into dotnet:master Dec 30, 2020
@Tratcher Tratcher deleted the tratcher/middleware/obsolete branch December 30, 2020 16:54
@Tratcher Tratcher mentioned this pull request Dec 30, 2020
Closed
@ShreyasJejurkar ShreyasJejurkar mentioned this pull request Feb 4, 2022
Closed
@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia Awaiting requested review from captainsafia

@halter73 halter73 Awaiting requested review from halter73

1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Tratcher Tratcher

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Milestone
6.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@Tratcher @pranavkm @amcasey