[SignalR] Ignore ODE with AsyncEnumerables #28894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Dec 30, 2020
| { | ||
| // cancellationToken is passed in by the user, and if they call cancel after the | ||
| // enumerator is finished but before the enumerator is disposed | ||
| // then _cts might already be disposed by our wrapping code |
There was a problem hiding this comment.
I don't think we should be throwing first-chance exceptions for a fairly common usage pattern. Can we combine MakeCancelableTypedAsyncEnumerable with CastIAsyncEnumerable in a way that ensures the registration is always disposed before CastIAsyncEnumerable disposes the CTS? The current layering makes it difficult, but if those were combined it should be easy enough.
We could also consider not disposing the CTS at all, but I'd prefer disposing it if it's straightforward enough.
There was a problem hiding this comment.
I went with the second option as fixing the layering will probably lead to a lot of duplicate code. And layering asyncenumerables on top of each other started annoying me 😆
BrennanConroy
force-pushed
the
brecon/canceldispose
branch
from
2098c60 to
d69bc42
Compare
halter73
approved these changes
Jan 22, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28241