Skip to content

Conversation

sayedihashimi
Copy link
Member

@sayedihashimi sayedihashimi commented Jan 25, 2021

I have modified the appSettings.json to have a comment that will help users configure Azure settings that are needed for org auth scenarios.

Note: the FWLink that the comment points to will be updated before these are released.

Before merging we will need to test the nuget packages that come out of the build. @phenning and @vijayrkn will assist in testing.

Replaces PR at #29604

Description

This includes a new comments in appSettings.json for asp.net core projects that have been created with Microsoft identity platform as the auth method.
In 16.9, the user will need to create some objects in Azure, and then specify the values in the appSettings.json.
This change includes an FWLink that will point to some docs that the user can follow to complete the process. I'm still working on that doc, so the
link is currently pointing to a general doc about Microsoft identity platform and asp.net core.
Later in 16.10, Visual Studio will do the work to provision the Azure objects and populate appSettings.json, but this comment will still be helpful
for users that create projects with dotnet new

Customer Impact

Helps users complete configuration of asp.net core projects created with Microsoft identity platform as the auth method.

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

Pretty low risk, the change just includes a comment in the appSettings.json files for asp.net core projects that support Microsoft identity platform auth.

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A
    Not sure what this question is asking here.

Addresses [issue number]
No issue tracking this currently

@sayedihashimi sayedihashimi requested a review from a team as a code owner January 25, 2021 23:12
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 25, 2021
@pranavkm pranavkm requested a review from phenning January 25, 2021 23:35
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok to me. @phenning could you have a look?

Our 5.0 branches are currently closed. @mkArtakMSFT could you be responsible for making sure this goes in once the branches are ready? Thanks!

@phenning
Copy link
Contributor

Changes look ok to me. @phenning could you have a look?

Our 5.0 branches are currently closed. @mkArtakMSFT could you be responsible for making sure this goes in once the branches are ready? Thanks!

:shipit:

@javiercn javiercn added the Servicing-consider Shiproom approval is required for the issue label Jan 26, 2021
@ghost
Copy link

ghost commented Jan 26, 2021

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@javiercn javiercn added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 26, 2021
@sayedihashimi
Copy link
Member Author

@phenning I noticed after going through VS the URL is messed up because some / characters were removed.
For example here is what I'm seeing

/*
The following identity settings need to be configured
before the project can be successfully executed.
For more info see https:aka.ms/dotnet-template-ms-identity-platform 
*/

@phenning can you take a look to see what could be happening here?

@phenning
Copy link
Contributor

phenning commented Jan 28, 2021 via email

@sayedihashimi
Copy link
Member Author

@phenning looks like escaping fixes the issue that I brought up. I've updated my PR with a new commit to fix that.

@mkArtakMSFT mkArtakMSFT added this to the 5.0.x milestone Feb 2, 2021
@leecow leecow added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Feb 2, 2021
@leecow leecow modified the milestones: 5.0.x, 5.0.4 Feb 2, 2021
@wtgodbe wtgodbe merged commit 6c22e5a into release/5.0 Feb 10, 2021
@wtgodbe wtgodbe deleted the sayedha/2021.01.template-appsettings-org02 branch February 10, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Servicing-approved Shiproom has approved the issue tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants