-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Fixes that Blazor focus extension could not focus SVG elements #35080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 😃 Just a small wording suggestion.
src/Components/test/testassets/BasicTestApp/SvgFocusComponent.razor
Outdated
Show resolved
Hide resolved
Many thanks for the help @MackinnonBuck |
I was also a bit unsure if I had to commit the files in |
@KristofferStrube You've done a great job identifying the necessary changes 🙂
Yes, we usually do commit those files. CI might fail if you don't. Would you be able to do so? |
Yep, I will get right on it but will have to build again locally first. |
Head branch was pushed to by a user without write access
Hey @MackinnonBuck some of the tests failed due to what I think was a timeout or unlucky disc access errors. Can the CI tasks that failed be retriggered somehow or should I do something to fix this? |
PR Title
Fixes that Blazor focus extension could not focus SVG elements
PR Description
I have added an extra case in the typescript wrapper for the focus extension that checks if the parsed element is an SVG element and also if it has a tabindex.
I have added a simple test that covers this behaviour.
Fixes #35046